Commitf74b00d

authored and

committed

Fix an issue where an empty grid can cause a bad pointer dereference (microsoft#8)

1 parent3a579a9 commitf74b00dCopy full SHA for f74b00d

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1094,7 +1094,10 @@ CreateFormControls (IN FORM_DISPLAY_ENGINE_FORM *FormData,`
`1094`	`1094`	`// Signal that the current grid no longer has scope. Controls added from this point forward will be added`
`1095`	`1095`	`// directly to the canvas (unless another grid is created).`
`1096`	`1096`	`//`
`1097`		`-if (LocalGrid->m_GridInitialHeight!=LocalGrid->m_GridCellHeight) {`
	`1097`	`+if (LocalGrid==NULL) {`
	`1098`	`+DEBUG ((DEBUG_ERROR,"ERROR [DE]: GridEndOp without valid StartGridOp\n"));`
	`1099`	`+ }`
	`1100`	`+if (LocalGrid!=NULL&&LocalGrid->m_GridInitialHeight!=LocalGrid->m_GridCellHeight) {`
`1098`	`1101`	`DEBUG ((DEBUG_ERROR,"ERROR [DE]: Grid elements larger than initial grid height. Correct VFR StartGridOp value.\r\n"));`
`1099`	`1102`	`}`
`1100`	`1103`	`GridScope= FALSE;`

Comments

(0)