Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitf7362f5

Browse files
fix for module suffix
1 parenteb75ac8 commitf7362f5

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

‎src/fsharp/vs/ServiceAnalysis.fs‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,15 @@ module UnusedOpens =
2929
|> List.choose(fun openDeclaration->
3030
match openDeclarationwith
3131
| FSharpOpenDeclaration.Open((firstId::_)as longId, modules, appliedScope)->
32-
Some{ Idents= modules|> List.choose(fun x-> x.TryFullName)|> Set.ofList
32+
Some{ Idents=
33+
modules
34+
|> List.choose(fun x-> x.TryFullName|> Option.map(fun fullName-> x, fullName))
35+
|> List.collect(fun(modul,fullName)->
36+
[yield fullName
37+
if modul.HasFSharpModuleSuffixthen
38+
yield fullName.[..fullName.Length-7]// "Module" length plus zero indexign correction
39+
])
40+
|> Set.ofList
3341
Modules= modules
3442
Range=
3543
letlastId= List.last longId

‎vsintegration/tests/unittests/UnusedOpensTests.fs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ module Top =
168168
=>[]
169169

170170
[<Test>]
171-
[<Ignore"Auto open modules are not supported yet">]
172171
let``last of several equivalent open declarations is market as used,the rest of them are marked as unused``()=
173172
"""
174173
module NormalModule =
@@ -197,7 +196,6 @@ type Class() = class end
197196
=>[]
198197

199198
[<Test>]
200-
[<Ignore"Extensions are not supported yet">]
201199
let``open declaration is not marked as unused if an extension property is used``()=
202200
"""
203201
module Module =
@@ -220,7 +218,6 @@ let _ = "a long string".Trim()
220218
=>[5,(5,11)]
221219

222220
[<Test>]
223-
[<Ignore"Extensions are not supported yet">]
224221
let``open declaration is not marked as unused if an extension method is used``()=
225222
"""
226223
type Class() = class end
@@ -550,7 +547,6 @@ open System
550547
=>[]
551548

552549
[<Test>]
553-
[<Ignore"Extensions are not supported yet">]
554550
let``open declaration is not marked as unused if a related type extension is used``()=
555551
"""
556552
module Module =

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp