Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite56ef20

Browse files
authored
Improve trace diagnostics for compiler service (#3061)
* cleanup* cleanup* diagnostics* cleanup diagnostics* even cleaner diagnostics* cleanup diagnostics* default tuning* adjust tuning, more logging* add test, fix whitespace
1 parent722a64a commite56ef20

File tree

61 files changed

+748
-640
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+748
-640
lines changed

‎src/fsharp/AugmentWithHashCompare.fs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
/// Generate the hash/compare functions we add to user-defined types by default.
44
moduleinternalMicrosoft.FSharp.Compiler.AugmentWithHashCompare
55

6-
openInternal.Utilities
76
openMicrosoft.FSharp.Compiler
87
openMicrosoft.FSharp.Compiler.AbstractIL
98
openMicrosoft.FSharp.Compiler.AbstractIL.IL
@@ -13,8 +12,6 @@ open Microsoft.FSharp.Compiler.Tast
1312
openMicrosoft.FSharp.Compiler.Tastops
1413
openMicrosoft.FSharp.Compiler.Ast
1514
openMicrosoft.FSharp.Compiler.ErrorLogger
16-
openMicrosoft.FSharp.Compiler.PrettyNaming
17-
openMicrosoft.FSharp.Compiler.Lib
1815
openMicrosoft.FSharp.Compiler.TcGlobals
1916
openMicrosoft.FSharp.Compiler.Infos
2017

‎src/fsharp/CheckFormatStrings.fs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@ module internal Microsoft.FSharp.Compiler.CheckFormatStrings
44

55
openInternal.Utilities
66
openMicrosoft.FSharp.Compiler
7-
openMicrosoft.FSharp.Compiler.AbstractIL
8-
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
97
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library
108
openMicrosoft.FSharp.Compiler.Ast
119
openMicrosoft.FSharp.Compiler.Range
12-
openMicrosoft.FSharp.Compiler.ErrorLogger
1310
openMicrosoft.FSharp.Compiler.Tast
1411
openMicrosoft.FSharp.Compiler.Tastops
1512
openMicrosoft.FSharp.Compiler.TcGlobals

‎src/fsharp/ConstraintSolver.fs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,10 @@ module internal Microsoft.FSharp.Compiler.ConstraintSolver
3030
//
3131
//-------------------------------------------------------------------------
3232

33-
openInternal.Utilities
3433
openInternal.Utilities.Collections
3534

3635
openMicrosoft.FSharp.Compiler
3736
openMicrosoft.FSharp.Compiler.AbstractIL
38-
openMicrosoft.FSharp.Compiler.AbstractIL.Diagnostics
3937
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
4038
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library
4139
openMicrosoft.FSharp.Compiler.Ast
@@ -51,7 +49,6 @@ open Microsoft.FSharp.Compiler.Rational
5149
openMicrosoft.FSharp.Compiler.InfoReader
5250
openMicrosoft.FSharp.Compiler.Tast
5351
openMicrosoft.FSharp.Compiler.Tastops
54-
openMicrosoft.FSharp.Compiler.Tastops.DebugPrint
5552
openMicrosoft.FSharp.Compiler.TcGlobals
5653
openMicrosoft.FSharp.Compiler.TypeRelations
5754

‎src/fsharp/FindUnsolved.fs‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,12 @@ module internal Microsoft.FSharp.Compiler.FindUnsolved
99
openInternal.Utilities
1010

1111
openMicrosoft.FSharp.Compiler
12-
openMicrosoft.FSharp.Compiler.AbstractIL
13-
openMicrosoft.FSharp.Compiler.AbstractIL.IL
1412
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
1513
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library
16-
openMicrosoft.FSharp.Compiler.AbstractIL.Diagnostics
17-
openMicrosoft.FSharp.Compiler.Range
18-
openMicrosoft.FSharp.Compiler.Ast
19-
openMicrosoft.FSharp.Compiler.ErrorLogger
2014
openMicrosoft.FSharp.Compiler.Tast
2115
openMicrosoft.FSharp.Compiler.Tastops
2216
openMicrosoft.FSharp.Compiler.TcGlobals
23-
openMicrosoft.FSharp.Compiler.Lib
24-
openMicrosoft.FSharp.Compiler.Layout
25-
openMicrosoft.FSharp.Compiler.AbstractIL.IL
2617
openMicrosoft.FSharp.Compiler.TypeRelations
27-
openMicrosoft.FSharp.Compiler.Infos
2818

2919
typeenv= Nix
3020

‎src/fsharp/InfoReader.fs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
/// Select members from a type by name, searching the type hierarchy if needed
55
moduleinternalMicrosoft.FSharp.Compiler.InfoReader
66

7-
openInternal.Utilities
8-
9-
openMicrosoft.FSharp.Compiler.AbstractIL
10-
openMicrosoft.FSharp.Compiler.AbstractIL.Diagnostics
117
openMicrosoft.FSharp.Compiler.AbstractIL.IL
128
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
139
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library

‎src/fsharp/MethodOverrides.fs‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,19 @@
33
/// Primary logic related to method overrides.
44
moduleinternalMicrosoft.FSharp.Compiler.MethodOverrides
55

6-
openInternal.Utilities
7-
openSystem.Text
8-
96
openMicrosoft.FSharp.Compiler
10-
openMicrosoft.FSharp.Compiler.AbstractIL
11-
openMicrosoft.FSharp.Compiler.AbstractIL.IL
127
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
138
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library
14-
openMicrosoft.FSharp.Compiler.AbstractIL.Diagnostics
159
openMicrosoft.FSharp.Compiler.Ast
1610
openMicrosoft.FSharp.Compiler.ErrorLogger
1711
openMicrosoft.FSharp.Compiler.Lib
1812
openMicrosoft.FSharp.Compiler.Infos
1913
openMicrosoft.FSharp.Compiler.AccessibilityLogic
2014
openMicrosoft.FSharp.Compiler.NameResolution
21-
openMicrosoft.FSharp.Compiler.PrettyNaming
2215
openMicrosoft.FSharp.Compiler.Range
2316
openMicrosoft.FSharp.Compiler.InfoReader
2417
openMicrosoft.FSharp.Compiler.Tast
2518
openMicrosoft.FSharp.Compiler.Tastops
26-
openMicrosoft.FSharp.Compiler.Tastops.DebugPrint
2719
openMicrosoft.FSharp.Compiler.TcGlobals
2820
openMicrosoft.FSharp.Compiler.TypeRelations
2921

‎src/fsharp/NameResolution.fs‎

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
// Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
22

3-
//-------------------------------------------------------------------------
4-
// Name environment and name resolution
5-
//-------------------------------------------------------------------------
6-
73

4+
/// Name environment and name resolution
85
moduleinternalMicrosoft.FSharp.Compiler.NameResolution
96

107
openInternal.Utilities
@@ -27,7 +24,6 @@ open Microsoft.FSharp.Compiler.Infos
2724
openMicrosoft.FSharp.Compiler.AccessibilityLogic
2825
openMicrosoft.FSharp.Compiler.AttributeChecking
2926
openMicrosoft.FSharp.Compiler.InfoReader
30-
openMicrosoft.FSharp.Compiler.Layout
3127
openMicrosoft.FSharp.Compiler.PrettyNaming
3228
openSystem.Collections.Generic
3329

@@ -4038,9 +4034,7 @@ and ResolvePartialLongIdentToClassOrRecdFieldsImpl (ncenv: NameResolver) (nenv:
40384034
|_->[]
40394035
modsOrNs@ qualifiedFields
40404036

4041-
(* Determining if an `Item` is resolvable at point by given `plid`. It's optimized by being lazy and early returning according to the given `Item`*)
4042-
4043-
letprivateResolveCompletionsInTypeForItem(ncenv:NameResolver)nenv m ad statics typ(item:Item):seq<Item>=
4037+
letResolveCompletionsInTypeForItem(ncenv:NameResolver)nenv m ad statics typ(item:Item):seq<Item>=
40444038
seq{
40454039
letg= ncenv.g
40464040
letamap= ncenv.amap
@@ -4209,7 +4203,7 @@ let private ResolveCompletionsInTypeForItem (ncenv: NameResolver) nenv m ad stat
42094203
|_->()
42104204
}
42114205

4212-
let recprivateResolvePartialLongIdentInTypeForItem(ncenv:NameResolver)nenv m ad statics plid(item:Item)typ=
4206+
let recResolvePartialLongIdentInTypeForItem(ncenv:NameResolver)nenv m ad statics plid(item:Item)typ=
42134207
seq{
42144208
letg= ncenv.g
42154209
letamap= ncenv.amap
@@ -4260,7 +4254,7 @@ let rec private ResolvePartialLongIdentInTypeForItem (ncenv: NameResolver) nenv
42604254
yield! finfo.FieldType(amap, m)|> ResolvePartialLongIdentInTypeForItem ncenv nenv m adfalse rest item
42614255
}
42624256

4263-
let recprivateResolvePartialLongIdentInModuleOrNamespaceForItem(ncenv:NameResolver)nenv m ad(modref:ModuleOrNamespaceRef)plid(item:Item)=
4257+
let recResolvePartialLongIdentInModuleOrNamespaceForItem(ncenv:NameResolver)nenv m ad(modref:ModuleOrNamespaceRef)plid(item:Item)=
42644258
letg= ncenv.g
42654259
letmty= modref.ModuleOrNamespaceType
42664260

@@ -4339,7 +4333,7 @@ let rec private ResolvePartialLongIdentInModuleOrNamespaceForItem (ncenv: NameRe
43394333
yield! tcref|> generalizedTyconRef|> ResolvePartialLongIdentInTypeForItem ncenv nenv m adtrue rest item
43404334
}
43414335

4342-
let recprivatePartialResolveLookupInModuleOrNamespaceAsModuleOrNamespaceThenLazy f plid(modref:ModuleOrNamespaceRef)=
4336+
let recPartialResolveLookupInModuleOrNamespaceAsModuleOrNamespaceThenLazy f plid(modref:ModuleOrNamespaceRef)=
43434337
letmty= modref.ModuleOrNamespaceType
43444338
match plidwith
43454339
|[]-> f modref
@@ -4349,7 +4343,7 @@ let rec private PartialResolveLookupInModuleOrNamespaceAsModuleOrNamespaceThenLa
43494343
PartialResolveLookupInModuleOrNamespaceAsModuleOrNamespaceThenLazy f rest(modref.NestedTyconRef mty)
43504344
| None-> Seq.empty
43514345

4352-
letprivatePartialResolveLongIndentAsModuleOrNamespaceThenLazy(nenv:NameResolutionEnv)plid f=
4346+
letPartialResolveLongIndentAsModuleOrNamespaceThenLazy(nenv:NameResolutionEnv)plid f=
43534347
seq{
43544348
match plidwith
43554349
| id:: rest->
@@ -4361,7 +4355,7 @@ let private PartialResolveLongIndentAsModuleOrNamespaceThenLazy (nenv:NameResolu
43614355
|[]->()
43624356
}
43634357

4364-
let recprivateGetCompletionForItem(ncenv:NameResolver)(nenv:NameResolutionEnv)m ad plid(item:Item):seq<Item>=
4358+
let recGetCompletionForItem(ncenv:NameResolver)(nenv:NameResolutionEnv)m ad plid(item:Item):seq<Item>=
43654359
seq{
43664360
letg= ncenv.g
43674361

‎src/fsharp/NicePrint.fs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,16 @@
66

77
moduleinternalMicrosoft.FSharp.Compiler.NicePrint
88

9-
openInternal.Utilities
109
openMicrosoft.FSharp.Compiler.AbstractIL
11-
openMicrosoft.FSharp.Compiler.AbstractIL.Diagnostics
1210
openMicrosoft.FSharp.Compiler.AbstractIL.IL
1311
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
1412
openMicrosoft.FSharp.Compiler.AbstractIL.Internal.Library
1513
openMicrosoft.FSharp.Compiler
16-
openMicrosoft.FSharp.Compiler.Range
1714
openMicrosoft.FSharp.Compiler.Rational
1815
openMicrosoft.FSharp.Compiler.Ast
1916
openMicrosoft.FSharp.Compiler.ErrorLogger
2017
openMicrosoft.FSharp.Compiler.Tast
2118
openMicrosoft.FSharp.Compiler.Tastops
22-
openMicrosoft.FSharp.Compiler.Tastops.DebugPrint
2319
openMicrosoft.FSharp.Compiler.TcGlobals
2420
openMicrosoft.FSharp.Compiler.Lib
2521
openMicrosoft.FSharp.Compiler.Infos

‎src/fsharp/PatternMatchCompilation.fs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
moduleinternalMicrosoft.FSharp.Compiler.PatternMatchCompilation
44

55
openSystem.Collections.Generic
6-
openInternal.Utilities
76
openMicrosoft.FSharp.Compiler
87
openMicrosoft.FSharp.Compiler.AbstractIL
98
openMicrosoft.FSharp.Compiler.AbstractIL.Internal
@@ -14,7 +13,6 @@ open Microsoft.FSharp.Compiler.Ast
1413
openMicrosoft.FSharp.Compiler.ErrorLogger
1514
openMicrosoft.FSharp.Compiler.Tast
1615
openMicrosoft.FSharp.Compiler.Tastops
17-
openMicrosoft.FSharp.Compiler.Infos
1816
openMicrosoft.FSharp.Compiler.Tastops.DebugPrint
1917
openMicrosoft.FSharp.Compiler.PrettyNaming
2018
openMicrosoft.FSharp.Compiler.TypeRelations

‎src/fsharp/PatternMatchCompilation.fsi‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ open Microsoft.FSharp.Compiler.TcGlobals
1212
openMicrosoft.FSharp.Compiler.Range
1313

1414

15-
1615
/// What should the decision tree contain for any incomplete match?
1716
typeActionOnFailure=
1817
| ThrowIncompleteMatchException

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp