Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite55de7e

Browse files
Vasily KirichenkoVasily Kirichenko
Vasily Kirichenko
authored and
Vasily Kirichenko
committed
revert FSharpEntity.TryFullName for namespaces
remove commented code
1 parent6960062 commite55de7e

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

‎src/fsharp/symbols/Symbols.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ and FSharpEntity(cenv:cenv, entity:EntityRef) =
310310
#else
311311
elif entity.IsTypeAbbrevthen None
312312
#endif
313-
elif entity.IsNamespacethen Some(entity.ToString())
313+
elif entity.IsNamespacethen Some entity.DemangledModuleOrNamespaceName
314314
else
315315
match entity.CompiledRepresentationwith
316316
| CompiledTypeRepr.ILAsmNamed(tref,_,_)-> Some tref.FullName

‎vsintegration/tests/unittests/UnusedOpensTests.fs‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ module M2 =
136136
=>[]
137137

138138
[<Test>]
139-
//[<Ignore "Relative open statements are not supported yet">]
140139
let``open a nested module inside another one is not unused,complex hierarchy``()=
141140
"""
142141
module Top =
@@ -151,7 +150,6 @@ module Top =
151150
=>[]
152151

153152
[<Test>]
154-
//[<Ignore "Relative open statements are not supported yet">]
155153
let``open a nested module inside another one is not unused,even more complex hierarchy``()=
156154
"""
157155
module Top =
@@ -275,7 +273,6 @@ let _ = DateTime.ExtensionMethod
275273
=>[]
276274

277275
[<Test>]
278-
//[<Ignore "Relative open statements are not supported yet">]
279276
let``static extension property applied to a type results that both namespaces/where the type is declared and where the extension is declared/is not marked as unused``()=
280277
"""
281278
module Extensions =
@@ -324,7 +321,6 @@ let _ = func()
324321
=>[]
325322

326323
[<Test>]
327-
//[<Ignore "Relative open statements are not supported yet">]
328324
let``open module all of which symbols are used by qualifier is marked as unused``()=
329325
"""
330326
module M =
@@ -379,7 +375,6 @@ let _ = Func<int, int>(fun _ -> 1)
379375
=>[]
380376

381377
[<Test>]
382-
//[<Ignore "Relative open statements are not supported yet">]
383378
let``open declaration is not marked as unused if a unit of measure defined in it is used``()=
384379
"""
385380
module M =
@@ -421,7 +416,6 @@ File.ReadAllLines ""
421416
=>[]
422417

423418
[<Test>]
424-
//[<Ignore "Relative open statements are not supported yet">]
425419
let``redundant opening a module with ModuleSuffix attribute value is marks as unused``()=
426420
"""
427421
[<CompilationRepresentation (CompilationRepresentationFlags.ModuleSuffix)>]
@@ -434,7 +428,6 @@ module M =
434428
=>[6,(9,33)]
435429

436430
[<Test>]
437-
//[<Ignore "Relative open statements are not supported yet">]
438431
let``redundant opening a module is marks as unused``()=
439432
"""
440433
module InternalModuleWithSuffix =
@@ -576,7 +569,6 @@ module Module =
576569
=>[]
577570

578571
[<Test>]
579-
//[<Ignore "Relative open statements are not supported yet">]
580572
let``record fields should be taken into account``()=
581573
"""
582574
module M1 =

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp