Commitd225014

Vasily Kirichenko

authored and

Vasily Kirichenko

committed

handle C# extension methods

1 parentaacb796 commitd225014Copy full SHA for d225014

File tree

+28

-0

lines changed

+28

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ open Microsoft.FSharp.Compiler.Range`
`8`	`8`
`9`	`9`	`moduleUnusedOpens=`
`10`	`10`	`openMicrosoft.FSharp.Compiler.PrettyNaming`
	`11`	`+openSystem.Runtime.CompilerServices`
`11`	`12`
`12`	`13`	`typeModule=`
`13`	`14`	`{ Entity:FSharpEntity`
`@@ -24,6 +25,14 @@ module UnusedOpens =`
`24`	`25`	`if ent.IsFSharpUnion&&not(Symbol.hasAttribute<RequireQualifiedAccessAttribute> ent.Attributes)then`
`25`	`26`	`for unionCasein ent.UnionCasesdo`
`26`	`27`	`yieldupcast unionCase`
	`28`	`+`
	`29`	`+if Symbol.hasAttribute<ExtensionAttribute> ent.Attributesthen`
	`30`	`+for fvin ent.MembersFunctionsAndValuesdo`
	`31`	+// fv.IsExtensionMember is always false for C# extension methods returning by `MembersFunctionsAndValues`,
	`32`	`+// so we have to check Extension attribute instead.`
	`33`	`+// (note: fv.IsExtensionMember has proper value for symbols returning by GetAllUsesOfAllSymbolsInFile though)`
	`34`	`+if Symbol.hasAttribute<ExtensionAttribute> fv.Attributesthen`
	`35`	`+yieldupcast fv`
`27`	`36`
`28`	`37`	`for fvin this.Entity.MembersFunctionsAndValuesdo`
`29`	`38`	`yieldupcast fv`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -703,4 +703,23 @@ let _ = x`
`703`	`703`	`"""`
`704`	`704`	`=>[]`
`705`	`705`
	`706`	`+[<Test>]`
	`707`	+let``C#extension methods are taken into account``()=
	`708`	`+"""`
	`709`	`+open System.Linq`
	`710`	`+`
	`711`	`+module Test =`
	`712`	`+ let xs = []`
	`713`	`+ let _ = xs.ToList()`
	`714`	`+"""`
	`715`	`+=>[]`
`706`	`716`
	`717`	`+[<Test>]`
	`718`	+let``namespace which contains types with C#extension methods is marked as unused if no extension is used``()=
	`719`	`+"""`
	`720`	`+open System.Linq`
	`721`	`+`
	`722`	`+module Test =`
	`723`	`+ let xs = []`
	`724`	`+"""`
	`725`	`+=>[2,(5,16)]`

Comments

(0)