Commitd08a5ff

authored and

committed

Fixing JaroWinkler tests with InvariantCulture and fixing async tests by removing Debugger.Break() (#3627)

* Fixing JaroWinkler tests to use InvariantCulture for number-to-string* Fixing the crashing of test runners because of a Debugger.Break() in a test

1 parent01eab69 commitd08a5ffCopy full SHA for d08a5ff

File tree

-3

lines changed

src/fsharp
- FSharp.Compiler.Unittests
  - EditDistance.fs
- FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Control
  - AsyncType.fs

-3

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`namespaceFSharp.Compiler.Unittests`
`3`	`3`
`4`	`4`	`openSystem`
	`5`	`+openSystem.Globalization`
`5`	`6`	`openSystem.Text`
`6`	`7`	`openNUnit.Framework`
`7`	`8`	`openMicrosoft.FSharp.Compiler`
`@@ -16,7 +17,7 @@ module EditDistance =`
`16`	`17`	`[<TestCase("DWAYNE","DUANE", ExpectedResult="0.840")>]`
`17`	`18`	`[<TestCase("DIXON","DICKSONX", ExpectedResult="0.813")>]`
`18`	`19`	`letJaroWinklerTest(str1:string,str2:string):string=`
`19`		`- String.Format("{0:0.000}", JaroWinklerDistance str1 str2)`
	`20`	`+ String.Format(CultureInfo.InvariantCulture,"{0:0.000}", JaroWinklerDistance str1 str2)`
`20`	`21`
`21`	`22`	`[<Test>]`
`22`	`23`	`[<TestCase("RICK","RICK", ExpectedResult=0)>]`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,6 @@ type AsyncType() =`
`177`	`177`	`match a.InnerExceptionwith`
`178`	`178`	`\|:? TaskCanceledExceptionas t->()`
`179`	`179`	`\|_-> reraise()`
`180`		`- System.Diagnostics.Debugger.Break()\|> ignore`
`181`	`180`	`Assert.IsTrue(t.IsCompleted,"Task is not completed")`
`182`	`181`
`183`	`182`	`[<Test>]`
`@@ -408,4 +407,4 @@ type AsyncType() =`
`408`	`407`	`cts.Cancel()`
`409`	`408`	`ewh.WaitOne(10000)\|> ignore`
`410`	`409`
`411`		`-#endif`
	`410`	`+#endif`

Comments

(0)