Movatterモバイル変換

Skip to content

Pateldisolution/fsharp-1Public

forked fromfsharp/fsharp

NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commitcc8b91c

cartermp

Kevin Ransom

authored and

Kevin Ransom

committed

Clean up IntelliSense perf UI and flow options for IntelliSense (#5211)

* Clean up IntelliSense perf UI and flow options for IntelliSense* Tooltips, bindings, and removing redundant code* Change tooltip to include guidance and un-bind project options

1 parent8d66249 commitcc8b91cCopy full SHA for cc8b91c

File tree

34 files changed

+600

-57

lines changed

vsintegration/src
- FSharp.Editor
  - CodeFix
  - Commands
    - HelpContextService.fs
  - Completion
    - CompletionProvider.fs
  - Diagnostics
  - DocumentHighlights
    - DocumentHighlightsService.fs
  - InlineRename
    - InlineRenameService.fs
  - LanguageService
    - FSharpCheckerExtensions.fs
    - SymbolHelpers.fs
  - Navigation
    - FindUsagesService.fs
    - GoToDefinition.fs
  - Options
    - EditorOptions.fs
  - QuickInfo
    - QuickInfoProvider.fs
- FSharp.UIResources

34 files changed

+600

-57

lines changed

`‎vsintegration/src/FSharp.Editor/CodeFix/AddOpenCodeFixProvider.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ type internal FSharpAddOpenCodeFixProvider`
`98`	`98`	`letdocument= context.Document`
`99`	`99`	`let!parsingOptions,projectOptions= projectInfoManager.TryGetOptionsForEditingDocumentOrProject document`
`100`	`100`	`let!sourceText= context.Document.GetTextAsync(context.CancellationToken)`
`101`		`-let!_,parsedInput,checkResults= checker.ParseAndCheckDocument(document, projectOptions, allowStaleResults=true, sourceText= sourceText, userOpName= userOpName)`
	`101`	`+let!_,parsedInput,checkResults= checker.ParseAndCheckDocument(document, projectOptions, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, sourceText= sourceText, userOpName= userOpName)`
`102`	`102`	`letline= sourceText.Lines.GetLineFromPosition(context.Span.End)`
`103`	`103`	`letlinePos= sourceText.Lines.GetLinePosition(context.Span.End)`
`104`	`104`	`letdefines= CompilerEnvironment.GetCompilationDefinesForEditing parsingOptions`

`‎vsintegration/src/FSharp.Editor/CodeFix/ImplementInterfaceCodeFixProvider.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ type internal FSharpImplementInterfaceCodeFixProvider`
`141`	`141`	`let!parsingOptions,projectOptions= projectInfoManager.TryGetOptionsForEditingDocumentOrProject context.Document`
`142`	`142`	`letcancellationToken= context.CancellationToken`
`143`	`143`	`let!sourceText= context.Document.GetTextAsync(cancellationToken)`
`144`		`-let!_,parsedInput,checkFileResults= checker.ParseAndCheckDocument(context.Document, projectOptions, sourceText= sourceText, allowStaleResults=true, userOpName= userOpName)`
	`144`	`+let!_,parsedInput,checkFileResults= checker.ParseAndCheckDocument(context.Document, projectOptions, sourceText= sourceText, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`145`	`145`	`lettextLine= sourceText.Lines.GetLineFromPosition context.Span.Start`
`146`	`146`	`letdefines= CompilerEnvironment.GetCompilationDefinesForEditing parsingOptions`
`147`	`147`	`// Notice that context.Span doesn't return reliable ranges to find tokens at exact positions.`

`‎vsintegration/src/FSharp.Editor/CodeFix/RenameUnusedValue.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ type internal FSharpRenameUnusedValueCodeFixProvider`
`58`	`58`	`// where backtickes are replaced with parens.`
`59`	`59`	ifnot(PrettyNaming.IsOperatorOrBacktickedName ident)&&not(ident.StartsWith"``")then
`60`	`60`	`let!parsingOptions,projectOptions= projectInfoManager.TryGetOptionsForEditingDocumentOrProject document`
`61`		`-let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, allowStaleResults=true, sourceText= sourceText, userOpName=userOpName)`
	`61`	`+let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, sourceText= sourceText, userOpName=userOpName)`
`62`	`62`	`letm= RoslynHelpers.TextSpanToFSharpRange(document.FilePath, context.Span, sourceText)`
`63`	`63`	`letdefines= CompilerEnvironment.GetCompilationDefinesForEditing parsingOptions`
`64`	`64`	`let!lexerSymbol= Tokenizer.getSymbolAtPosition(document.Id, sourceText, context.Span.Start, document.FilePath, defines, SymbolLookupKind.Greedy,false)`

`‎vsintegration/src/FSharp.Editor/Commands/HelpContextService.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ type internal FSharpHelpContextService`
`25`	`25`	`static letuserOpName="ImplementInterfaceCodeFix"`
`26`	`26`	`static memberGetHelpTerm(checker:FSharpChecker,sourceText:SourceText,fileName,options,span:TextSpan,tokens:List<ClassifiedSpan>,textVersion):Async<stringoption>=`
`27`	`27`	`asyncMaybe{`
`28`		`-let!_,_,check= checker.ParseAndCheckDocument(fileName, textVersion, sourceText.ToString(), options, allowStaleResults=true, userOpName= userOpName)`
	`28`	`+let!_,_,check= checker.ParseAndCheckDocument(fileName, textVersion, sourceText.ToString(), options, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`29`	`29`	`lettextLines= sourceText.Lines`
`30`	`30`	`letlineInfo= textLines.GetLineFromPosition(span.Start)`
`31`	`31`	`letline= lineInfo.LineNumber`

`‎vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ type internal FSharpCompletionProvider`
`103`	`103`	`static memberProvideCompletionsAsyncAux(checker:FSharpChecker,sourceText:SourceText,caretPosition:int,options:FSharpProjectOptions,filePath:string,`
`104`	`104`	`textVersionHash:int,getAllSymbols:FSharpCheckFileResults->AssemblySymbol list)=`
`105`	`105`	`asyncMaybe{`
`106`		`-let!parseResults,_,checkFileResults= checker.ParseAndCheckDocument(filePath, textVersionHash, sourceText.ToString(), options, allowStaleResults=true, userOpName= userOpName)`
	`106`	`+let!parseResults,_,checkFileResults= checker.ParseAndCheckDocument(filePath, textVersionHash, sourceText.ToString(), options, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`107`	`107`
`108`	`108`	`lettextLines= sourceText.Lines`
`109`	`109`	`letcaretLinePos= textLines.GetLinePosition(caretPosition)`

`‎vsintegration/src/FSharp.Editor/Diagnostics/SimplifyNameDiagnosticAnalyzer.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ type internal SimplifyNameDiagnosticAnalyzer() =`
`62`	`62`	`\|_->`
`63`	`63`	`let!sourceText= document.GetTextAsync()`
`64`	`64`	`letchecker= getChecker document`
`65`		`-let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, sourceText= sourceText, allowStaleResults=true, userOpName=userOpName)`
	`65`	`+let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, sourceText= sourceText, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName=userOpName)`
`66`	`66`	`let!symbolUses= checkResults.GetAllUsesOfAllSymbolsInFile()\|> liftAsync`
`67`	`67`	`let mutableresult= ResizeArray()`
`68`	`68`	`letsymbolUses=`

`‎vsintegration/src/FSharp.Editor/Diagnostics/UnusedDeclarationsAnalyzer.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ type internal UnusedDeclarationsAnalyzer() =`
`110`	`110`	`\| Some(_parsingOptions, projectOptions)->`
`111`	`111`	`let!sourceText= document.GetTextAsync()`
`112`	`112`	`letchecker= getChecker document`
`113`		`-let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, sourceText= sourceText, allowStaleResults=true, userOpName= userOpName)`
	`113`	`+let!_,_,checkResults= checker.ParseAndCheckDocument(document, projectOptions, sourceText= sourceText, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`114`	`114`	`let!allSymbolUsesInFile= checkResults.GetAllUsesOfAllSymbolsInFile()\|> liftAsync`
`115`	`115`	`letunusedRanges= getUnusedDeclarationRanges allSymbolUsesInFile(isScriptFile document.FilePath)`
`116`	`116`	`return`

`‎vsintegration/src/FSharp.Editor/Diagnostics/UnusedOpensDiagnosticAnalyzer.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ type internal UnusedOpensDiagnosticAnalyzer() =`
`43`	`43`	`asyncMaybe{`
`44`	`44`	`do! Option.guard Settings.CodeFixes.UnusedOpens`
`45`	`45`	`let!sourceText= document.GetTextAsync()`
`46`		`-let!_,_,checkResults= checker.ParseAndCheckDocument(document, options, sourceText= sourceText, allowStaleResults=true, userOpName= userOpName)`
	`46`	`+let!_,_,checkResults= checker.ParseAndCheckDocument(document, options, sourceText= sourceText, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`47`	`47`	`#if DEBUG`
`48`	`48`	`letsw= Stopwatch.StartNew()`
`49`	`49`	`#endif`

`‎vsintegration/src/FSharp.Editor/DocumentHighlights/DocumentHighlightsService.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ type internal FSharpDocumentHighlightsService [<ImportingConstructor>] (checkerP`
`59`	`59`	`lettextLinePos= sourceText.Lines.GetLinePosition(position)`
`60`	`60`	`letfcsTextLineNumber= Line.fromZ textLinePos.Line`
`61`	`61`	`let!symbol= Tokenizer.getSymbolAtPosition(documentKey, sourceText, position, filePath, defines, SymbolLookupKind.Greedy,false)`
`62`		`-let!_,_,checkFileResults= checker.ParseAndCheckDocument(filePath, textVersionHash, sourceText.ToString(), options, allowStaleResults=true, userOpName= userOpName)`
	`62`	`+let!_,_,checkFileResults= checker.ParseAndCheckDocument(filePath, textVersionHash, sourceText.ToString(), options, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`63`	`63`	`let!symbolUse= checkFileResults.GetSymbolUseAtLocation(fcsTextLineNumber, symbol.Ident.idRange.EndColumn, textLine.ToString(), symbol.FullIsland, userOpName=userOpName)`
`64`	`64`	`let!symbolUses= checkFileResults.GetUsesOfSymbolInFile(symbolUse.Symbol)\|> liftAsync`
`65`	`65`	`return`

`‎vsintegration/src/FSharp.Editor/InlineRename/InlineRenameService.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ type internal InlineRenameService`
`149`	`149`	`lettextLinePos= sourceText.Lines.GetLinePosition(position)`
`150`	`150`	`letfcsTextLineNumber= Line.fromZ textLinePos.Line`
`151`	`151`	`let!symbol= Tokenizer.getSymbolAtPosition(document.Id, sourceText, position, document.FilePath, defines, SymbolLookupKind.Greedy,false)`
`152`		`-let!_,_,checkFileResults= checker.ParseAndCheckDocument(document, options, allowStaleResults=true, userOpName= userOpName)`
	`152`	`+let!_,_,checkFileResults= checker.ParseAndCheckDocument(document, options, allowStaleResults=Settings.LanguageServicePerformance.AllowStaleCompletionResults, userOpName= userOpName)`
`153`	`153`	`let!symbolUse= checkFileResults.GetSymbolUseAtLocation(fcsTextLineNumber, symbol.Ident.idRange.EndColumn, textLine.Text.ToString(), symbol.FullIsland, userOpName=userOpName)`
`154`	`154`	`let!declLoc= symbolUse.GetDeclarationLocation(document)`
`155`	`155`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp