NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commitca4dc83

committed

use TcRef.LogicalName instead of Stamp to calculate completion item hash code while filtering duplicates, letting ItemDisplayPartialEquality.Equals do the job

1 parentc0b044c commitca4dc83Copy full SHA for ca4dc83

File tree

1 file changed

-3

lines changed

src/fsharp/symbols
- SymbolHelpers.fs

1 file changed

-3

lines changed

`‎src/fsharp/symbols/SymbolHelpers.fs‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,7 @@ module internal SymbolHelpers =`
`782`	`782`	`protectAssemblyExploration1027(fun()->`
`783`	`783`	`match itemwith`
`784`	`784`	`\| ItemWhereTypIsPreferred ty->`
`785`		`-if isAppTy g tythen hash(tcrefOfAppTy g ty).Stamp`
	`785`	`+if isAppTy g tythen hash(tcrefOfAppTy g ty).LogicalName`
`786`	`786`	`else1010`
`787`	`787`	`\| Item.ILField(ILFieldInfo(_, fld))->`
`788`	`788`	`System.Runtime.CompilerServices.RuntimeHelpers.GetHashCode fld// hash on the object identity of the AbstractIL metadata blob for the field`
`@@ -795,12 +795,12 @@ module internal SymbolHelpers =`
`795`	`795`	`\| Item.CtorGroup(name, meths)-> name.GetHashCode()+(meths\|> List.fold(fun st a-> st+ a.ComputeHashCode())0)`
`796`	`796`	`\|(Item.Value vref\| Item.CustomBuilder(_, vref))-> hash vref.LogicalName`
`797`	`797`	`\| Item.ActivePatternCase(APElemRef(_apinfo, vref, idx))-> hash(vref.LogicalName, idx)`
`798`		`-\| Item.ExnCase(tcref)-> hash tcref.Stamp`
	`798`	`+\| Item.ExnCase(tcref)-> hash tcref.LogicalName`
`799`	`799`	`\| Item.UnionCase(UnionCaseInfo(_, UCRef(tcref, n)),_)-> hash(tcref.Stamp, n)`
`800`	`800`	`\| Item.RecdField(RecdFieldInfo(_, RFRef(tcref, n)))-> hash(tcref.Stamp, n)`
`801`	`801`	`\| Item.Event evt-> evt.ComputeHashCode()`
`802`	`802`	`\| Item.Property(_name, pis)-> hash(pis\|> List.map(fun pi-> pi.ComputeHashCode()))`
`803`		`-\| Item.UnqualifiedType(tcref::_)-> hash tcref.Stamp`
	`803`	`+\| Item.UnqualifiedType(tcref::_)-> hash tcref.LogicalName`
`804`	`804`	`\|_-> failwith"unreachable")}`
`805`	`805`
`806`	`806`	`letCompletionItemDisplayPartialEquality g=`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitca4dc83

File tree

1 file changed

1 file changed

`‎src/fsharp/symbols/SymbolHelpers.fs‎`

0 commit comments