Commitc67349d

authored and

committed

Better error message for array ranks (#2637)

1 parentac3e0cc commitc67349dCopy full SHA for c67349d

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1249,7 +1249,7 @@ typeInfoCallsWord,"Calls"`
`1249`	`1249`	`3134,parsMutableOnAutoPropertyShouldBeGetSet,"Property definitions may not be declared mutable. To indicate that this property can be set, use 'member val PropertyName = expr with get,set'."`
`1250`	`1250`	`3135,parsMutableOnAutoPropertyShouldBeGetSetNotJustSet,"To indicate that this property can be set, use 'member val PropertyName = expr with get,set'."`
`1251`	`1251`	`3136,chkNoByrefsOfByrefs,"Type '%s' is illegal because in byref<T>, T cannot contain byref types."`
`1252`		`-3138,tastopsMaxArrayThirtyTwo,"F# supportsa maximum array rank of 32"`
	`1252`	`+3138,tastopsMaxArrayThirtyTwo,"F# supportsarray ranks between 1 and 32. The value %d is not allowed."`
`1253`	`1253`	`3139,tcNoIntegerForLoopInQuery,"In queries, use the form 'for x in n .. m do ...' for ranging over integers"`
`1254`	`1254`	`3140,tcNoWhileInQuery,"'while' expressions may not be used in queries"`
`1255`	`1255`	`3141,tcNoTryFinallyInQuery,"'try/finally' expressions may not be used in queries"`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -543,8 +543,7 @@ let mkByrefTy (g:TcGlobals) ty = TType_app (g.byref_tcr, [ty])`
`543`	`543`
`544`	`544`	`letmkArrayTy(g:TcGlobals)rank ty m=`
`545`	`545`	`if rank<1\|\| rank>32then`
`546`		`-// TODO : Provide a better message for zero/negative inputs here.`
`547`		`- errorR(Error(FSComp.SR.tastopsMaxArrayThirtyTwo(),m));`
	`546`	`+ errorR(Error(FSComp.SR.tastopsMaxArrayThirtyTwo(rank),m))`
`548`	`547`	`TType_app(g.il_arr_tcr_map.[3],[ty])`
`549`	`548`	`else`
`550`	`549`	`TType_app(g.il_arr_tcr_map.[rank-1],[ty])`

Comments

(0)