Commitb99f487

authored

Disallow byref field on IsByRefLike structs (#5103)

* Disallow byref field on IsByRefLike structs* Added test for IsByRefLike on a struct. Updated baselines

1 parente6c2a38 commitb99f487Copy full SHA for b99f487

File tree

+30

-1

lines changed

+30

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1543,10 +1543,12 @@ let CheckRecdField isUnion cenv env (tycon:Tycon) (rfield:RecdField) =`
`1543`	`1543`	`(not isUnion&& IsHiddenRecdField env.sigToImplRemapInfo(tcref.MakeNestedRecdFieldRef rfield))`
`1544`	`1544`	`letaccess= AdjustAccess isHidden(fun()-> tycon.CompilationPath) rfield.Accessibility`
`1545`	`1545`	`CheckTypeForAccess cenv env(fun()-> rfield.Name) access m rfield.FormalType`
`1546`		`-`
	`1546`	`+`
`1547`	`1547`	`if TyconRefHasAttribute g m g.attrib_IsByRefLikeAttribute tcrefthen`
`1548`	`1548`	`// Permit Span fields in IsByRefLike types`
`1549`	`1549`	`CheckTypePermitOuterSpanLike cenv env m rfield.FormalType`
	`1550`	`+if cenv.reportErrorsthen`
	`1551`	`+ CheckForByrefType cenv env rfield.FormalType(fun()-> errorR(Error(FSComp.SR.chkCantStoreByrefValue(), tycon.Range)))`
`1550`	`1552`	`else`
`1551`	`1553`	`CheckTypeNoByrefs cenv env m rfield.FormalType`
`1552`	`1554`	`if cenv.reportErrorsthen`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,3 +64,13 @@ neg107.fsx(53,34,53,38): typecheck error FS3234: Struct members cannot return th`
`64`	`64`	`neg107.fsx(67,34,67,40): typecheck error FS3234: Struct members cannotreturn the address of fields of the struct by reference`
`65`	`65`
`66`	`66`	`neg107.fsx(67,34,67,38): typecheck error FS3234: Struct members cannotreturn the address of fields of the struct by reference`
	`67`	`+`
	`68`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This isnot permitted by the rules of Common IL.`
	`69`	`+`
	`70`	`+neg107.fsx(71,14,71,18): typecheck error FS0437: A type would store a byref typed value. This isnot permitted by Common IL.`
	`71`	`+`
	`72`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This isnot permitted by the rules of Common IL.`
	`73`	`+`
	`74`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This isnot permitted by the rules of Common IL.`
	`75`	`+`
	`76`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This isnot permitted by the rules of Common IL.`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,3 +65,10 @@ namespace Test`
`65`	`65`	`val mutablex:TestMut1`
`66`	`66`
`67`	`67`	`memberthis.XAddr=&this.x.x// not allowed, Struct members cannot return the address of fields of the struct by reference", not entirely clear why C# disallowed this`
	`68`	`+`
	`69`	`+moduleDisallowIsByRefLikeWithByRefField=`
	`70`	`+[<IsByRefLike;Struct>]`
	`71`	`+typeBeef(x:byref<int>)=`
	`72`	`+`
	`73`	`+member__.X=&x`
	`74`	`+`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,3 +64,13 @@ neg107.fsx(53,34,53,38): typecheck error FS3234: Struct members cannot return th`
`64`	`64`	`neg107.fsx(67,34,67,40): typecheck error FS3234: Struct members cannot return the address of fields of the struct by reference`
`65`	`65`
`66`	`66`	`neg107.fsx(67,34,67,38): typecheck error FS3234: Struct members cannot return the address of fields of the struct by reference`
	`67`	`+`
	`68`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This is not permitted by the rules of Common IL.`
	`69`	`+`
	`70`	`+neg107.fsx(71,14,71,18): typecheck error FS0437: A type would store a byref typed value. This is not permitted by Common IL.`
	`71`	`+`
	`72`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This is not permitted by the rules of Common IL.`
	`73`	`+`
	`74`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This is not permitted by the rules of Common IL.`
	`75`	`+`
	`76`	`+neg107.fsx(71,19,71,20): typecheck error FS0412: A type instantiation involves a byref type. This is not permitted by the rules of Common IL.`

Comments

(0)