Commit992a3d6

authored and

committed

use index comparison instead of pointer comparison (#2976)

1 parent7e964bb commit992a3d6Copy full SHA for 992a3d6

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2363,9 +2363,10 @@ and ResolveOverloading`
`2363`	`2363`
`2364`	`2364`
`2365`	`2365`	`letbestMethods=`
`2366`		`- applicableMeths\|> List.choose(fun candidate->`
`2367`		`-if applicableMeths\|> List.forall(fun other->`
`2368`		`- p13 candidate=== p13 other\|\|// REVIEW: change this needless use of pointer equality to be an index comparison`
	`2366`	`+letindexedApplicableMeths= applicableMeths\|> List.indexed`
	`2367`	`+ indexedApplicableMeths\|> List.choose(fun(i,candidate)->`
	`2368`	`+if indexedApplicableMeths\|> List.forall(fun(j,other)->`
	`2369`	`+ i= j\|\|`
`2369`	`2370`	`letres= better candidate other`
`2370`	`2371`	`//eprintfn "\n-------\nCandidate: %s\nOther: %s\nResult: %d\n" (NicePrint.stringOfMethInfo amap m denv (fst candidate).Method) (NicePrint.stringOfMethInfo amap m denv (fst other).Method) res`
`2371`	`2372`	`res>0)then`

Comments

(0)