Commit92fc550

joj

authored and

KevinRansom

committed

Check for non-empty paths when stripping ending semicolon (#3319)

In some projects (Android in particular) the framework paths are empty. This results in an exception when trying to open the Add References dialog. This behavior is reported in issuedotnet/fsharp#3318. This commit resolves that issue.

1 parent9fe6e22 commit92fc550Copy full SHA for 92fc550

File tree

1 file changed

-1

lines changed

vsintegration/src/FSharp.ProjectSystem.FSharp
- Project.fs

1 file changed

-1

lines changed

`‎vsintegration/src/FSharp.ProjectSystem.FSharp/Project.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1012,7 +1012,7 @@ namespace rec Microsoft.VisualStudio.FSharp.ProjectSystem`
`1012`	`1012`
`1013`	`1013`	`letstripEndingSemicolon(sb:StringBuilder)=`
`1014`	`1014`	`letlen= sb.Length`
`1015`		`-if sb.[len-1]=';'then sb.Remove(len-1,1)\|> ignore`
	`1015`	`+iflen>0&&sb.[len-1]=';'then sb.Remove(len-1,1)\|> ignore`
`1016`	`1016`	`()`
`1017`	`1017`
`1018`	`1018`	`lettargetFrameworkMoniker= this.GetTargetFrameworkMoniker()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit92fc550

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.ProjectSystem.FSharp/Project.fs‎`

0 commit comments