Commit8adfa2f

cartermp

authored and

KevinRansom

committed

Do not commit autocompletion on bracket or pipe chars (#3718)

* Do not commit autocompletion on bracket or pipe chars* Remove accidentally added open statement

1 parent503d167 commit8adfa2fCopy full SHA for 8adfa2f

File tree

1 file changed

+16

-2

lines changed

vsintegration/src/FSharp.Editor/Completion
- CompletionProvider.fs

1 file changed

+16

-2

lines changed

`‎vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs‎`

Lines changed: 16 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,23 @@ type internal FSharpCompletionProvider`
`55`	`55`
`56`	`56`	`letxmlMemberIndexService= serviceProvider.GetService(typeof<IVsXMLMemberIndexService>):?> IVsXMLMemberIndexService`
`57`	`57`	`letdocumentationBuilder= XmlDocumentation.CreateDocumentationBuilder(xmlMemberIndexService, serviceProvider.DTE)`
`58`		`-`
	`58`	`+`
`59`	`59`	`static letnoCommitOnSpaceRules=`
`60`		`- CompletionItemRules.Default.WithCommitCharacterRule(CharacterSetModificationRule.Create(CharacterSetModificationKind.Remove,' ','=',',','.','<','>','(',')','!',':'))`
	`60`	`+// These are important. They make sure we don't _commit_ autocompletion when people don't expect them to. Some examples:`
	`61`	`+//`
	`62`	`+// * type Foo() =`
	`63`	`+// member val a = 12 with get, <<---- Don't commit autocomplete!`
	`64`	`+//`
	`65`	`+// * type MyRecord = { name: <<---- Don't commit autocomplete!`
	`66`	`+//`
	`67`	`+// * type My< <<---- Don't commit autocomplete!`
	`68`	`+//`
	`69`	`+// * let myClassInstance = MyClass(Date= <<---- Don't commit autocomplete!`
	`70`	`+//`
	`71`	`+// * let xs = [1..10] <<---- Don't commit autocomplete! (same for arrays)`
	`72`	`+letnoCommitChars=[\|' ';'=';',';'.';'<';'>';'(';')';'!';':';'[';']';'\|'\|].ToImmutableArray()`
	`73`	`+`
	`74`	`+ CompletionItemRules.Default.WithCommitCharacterRule(CharacterSetModificationRule.Create(CharacterSetModificationKind.Remove, noCommitChars))`
`61`	`75`
`62`	`76`	`static letgetRules()=if Settings.IntelliSense.ShowAfterCharIsTypedthen noCommitOnSpaceRuleselse CompletionItemRules.Default`
`63`	`77`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8adfa2f

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs‎`

0 commit comments