Commit7b7776e

authored and

committed

no completion on name of value and function declaration (#5083)

1 parent0e851c6 commit7b7776eCopy full SHA for 7b7776e

File tree

+31

-1

lines changed

+31

-1

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1248,6 +1248,9 @@ module UntypedParseImpl =`
`1248`	`1248`	`\|_-> defaultTraverse synBinding`
`1249`	`1249`
`1250`	`1250`	`match headPatwith`
	`1251`	`+\| SynPat.LongIdent(longDotId= lidwd)when rangeContainsPos lidwd.Range pos->`
	`1252`	`+// let fo\|o x = ()`
	`1253`	`+ Some CompletionContext.Invalid`
`1251`	`1254`	`\| SynPat.LongIdent(_,_,_,ctorArgs,_,_)->`
`1252`	`1255`	`match ctorArgswith`
`1253`	`1256`	`\| SynConstructorArgs.Pats(pats)->`
`@@ -1264,6 +1267,9 @@ module UntypedParseImpl =`
`1264`	`1267`	`\|_-> visitParam pat`
`1265`	`1268`	`)`
`1266`	`1269`	`\|_-> defaultTraverse synBinding`
	`1270`	`+\| SynPat.Named(range= range)when rangeContainsPos range pos->`
	`1271`	`+// let fo\|o = 1`
	`1272`	`+ Some CompletionContext.Invalid`
`1267`	`1273`	`\|_-> defaultTraverse synBinding`
`1268`	`1274`
`1269`	`1275`	`member__.VisitHashDirective(range)=`

Lines changed: 25 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -457,13 +457,37 @@ type T`
`457`	`457`	`VerifyNoCompletionList(fileContents,"type T")`
`458`	`458`
`459`	`459`	`[<Test>]`
`460`		-let``No completion onfunctionnameat declaration site``()=
	`460`	+let``No completion on nameof unfinished function declaration``()=
`461`	`461`	`letfileContents="""`
`462`	`462`	`let f`
`463`	`463`
`464`	`464`	`"""`
`465`	`465`	`VerifyNoCompletionList(fileContents,"let f")`
`466`	`466`
	`467`	`+[<Test>]`
	`468`	+let``No completion on name of value declaration``()=
	`469`	`+letfileContents="""`
	`470`	`+let xyz = 1`
	`471`	`+`
	`472`	`+"""`
	`473`	`+ VerifyNoCompletionList(fileContents,"let xy")`
	`474`	`+`
	`475`	`+[<Test>]`
	`476`	+let``No completion on name of function declaration``()=
	`477`	`+letfileContents="""`
	`478`	`+let foo x = 1`
	`479`	`+`
	`480`	`+"""`
	`481`	`+ VerifyNoCompletionList(fileContents,"let fo")`
	`482`	`+`
	`483`	`+[<Test>]`
	`484`	+let``No completion on name of tupled function declaration``()=
	`485`	`+letfileContents="""`
	`486`	`+let foo (x, y) = 1`
	`487`	`+`
	`488`	`+"""`
	`489`	`+ VerifyNoCompletionList(fileContents,"let fo")`
	`490`	`+`
`467`	`491`	`[<Test>]`
`468`	`492`	let``No completion on member name at declaration site``()=
`469`	`493`	`letfileContents="""`

Comments

(0)