Commit6085f0b

Vasily Kirichenko

authored and

Vasily Kirichenko

committed

consider definitions because they can be used at type extensions point

1 parent03ecab2 commit6085f0bCopy full SHA for 6085f0b

File tree

-2

lines changed

-2

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,12 +58,16 @@ module UnusedOpens =`
`58`	`58`
`59`	`59`	`letfilterSymbolUses(getSourceLineStr:int->string)(symbolUses:FSharpSymbolUse[]):FSharpSymbolUse[]=`
`60`	`60`	`symbolUses`
`61`		`-\|> Array.filter(fun su->not su.IsFromDefinition)`
`62`	`61`	`\|> Array.filter(fun su->`
`63`	`62`	`match su.Symbolwith`
`64`		`-\|:? FSharpMemberOrFunctionOrValueas fvwhen fv.IsExtensionMember->true`
	`63`	`+\|:? FSharpMemberOrFunctionOrValueas fvwhen fv.IsExtensionMember->`
	`64`	`+// extension members should be taken into account even though they have a prefix (as they do most of the time)`
	`65`	`+true`
`65`	`66`	`\|_->`
`66`	`67`	`letpartialName= QuickParse.GetPartialLongNameEx(getSourceLineStr su.RangeAlternate.StartLine, su.RangeAlternate.EndColumn-1)`
	`68`	`+// for the rest of symbols we pick only those which are the first part of a long idend, because it's they which are`
	`69`	+// conteined in opened namespaces / modules. For example, we pick `IO` from long ident `IO.File.OpenWrite` because
	`70`	+// it's `open System` which really brings it into scope.
`67`	`71`	`partialName.QualifyingIdents=[])`
`68`	`72`
`69`	`73`	`letgetUnusedOpens(checkFileResults:FSharpCheckFileResults,getSourceLineStr:int->string):Async<rangelist>=`

Comments

(0)