Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit578db47

Browse files
auduchinokKevinRansom
authored andcommitted
Use UTC timestamps in the compiler and service (#3889)
* Use UTC timestamps in compiler and service* Fix tests
1 parentfefae46 commit578db47

File tree

17 files changed

+84
-81
lines changed

17 files changed

+84
-81
lines changed

‎src/absil/il.fs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3656,7 +3656,7 @@ let computeILRefs modul =
36563656
{ AssemblyReferences= Seq.fold(fun acc x-> x::acc)[] s.refsA
36573657
ModuleReferences= Seq.fold(fun acc x-> x::acc)[] s.refsM}
36583658

3659-
lettspan= System.TimeSpan(System.DateTime.Now.Ticks- System.DateTime(2000,1,1).Ticks)
3659+
lettspan= System.TimeSpan(System.DateTime.UtcNow.Ticks- System.DateTime(2000,1,1).Ticks)
36603660

36613661
letparseILVersion(vstr:string)=
36623662
// matches "v1.2.3.4" or "1.2.3.4". Note, if numbers are missing, returns -1 (not 0).
@@ -3667,7 +3667,7 @@ let parseILVersion (vstr : string) =
36673667
// account for wildcards
36683668
if versionComponents.Length>2then
36693669
letdefaultBuild=(uint16)tspan.Days% System.UInt16.MaxValue-1us
3670-
letdefaultRevision=(uint16)(System.DateTime.Now.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
3670+
letdefaultRevision=(uint16)(System.DateTime.UtcNow.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
36713671
if versionComponents.[2]="*"then
36723672
if versionComponents.Length>3then
36733673
failwith"Invalid version format"

‎src/absil/illib.fs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1257,13 +1257,16 @@ module Shim =
12571257
abstractFileStreamReadShim: fileName:string->System.IO.Stream
12581258
abstractFileStreamCreateShim: fileName:string->System.IO.Stream
12591259
abstractFileStreamWriteExistingShim: fileName:string->System.IO.Stream
1260+
12601261
/// Take in a filename with an absolute path, and return the same filename
12611262
/// but canonicalized with respect to extra path separators (e.g. C:\\\\foo.txt)
12621263
/// and '..' portions
12631264
abstractGetFullPathShim: fileName:string->string
12641265
abstractIsPathRootedShim: path:string->bool
12651266
abstractIsInvalidPathShim: filename:string->bool
12661267
abstractGetTempPathShim :unit->string
1268+
1269+
/// Utc time of the last modification
12671270
abstractGetLastWriteTimeShim: fileName:string->System.DateTime
12681271
abstractSafeExists: fileName:string->bool
12691272
abstractFileDelete: fileName:string->unit
@@ -1303,7 +1306,7 @@ module Shim =
13031306

13041307
member__.GetTempPathShim()= System.IO.Path.GetTempPath()
13051308

1306-
member__.GetLastWriteTimeShim(fileName:string)= File.GetLastWriteTime fileName
1309+
member__.GetLastWriteTimeShim(fileName:string)= File.GetLastWriteTimeUtc fileName
13071310
member__.SafeExists(fileName:string)= System.IO.File.Exists fileName
13081311
member__.FileDelete(fileName:string)= System.IO.File.Delete fileName
13091312

‎src/absil/ilread.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3984,7 +3984,7 @@ let OpenILModuleReaderAfterReadingAllBytes infile opts =
39843984
opts.pdbPath.IsSome),true
39853985
with e->
39863986
System.Diagnostics.Debug.Assert(false, sprintf"Failed to compute key in OpenILModuleReaderAfterReadingAllBytes cache for '%s'. Falling back to uncached." infile)
3987-
("", System.DateTime.Now, ILScopeRef.Local,false),false
3987+
("", System.DateTime.UtcNow, ILScopeRef.Local,false),false
39883988

39893989
letcacheResult=
39903990
ifnot succeededthen None// Fall back to uncached.

‎src/fsharp/CompileOps.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2460,7 +2460,7 @@ type TcConfigBuilder =
24602460
isInvalidationSupported=false
24612461
sqmSessionGuid= None
24622462
sqmNumOfSourceFiles=0
2463-
sqmSessionStartedTime= System.DateTime.Now.Ticks
2463+
sqmSessionStartedTime= System.DateTime.UtcNow.Ticks
24642464
emitDebugInfoInQuotations=false
24652465
exename= None
24662466
copyFSharpCore=false

‎src/fsharp/FSharp.Build/FSharpEmbedResXSource.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ module internal {1} =
4242

4343
// simple up-to-date check
4444
if File.Exists(resx)&& File.Exists(sourcePath)&&
45-
File.GetLastWriteTime(resx)<= File.GetLastWriteTime(sourcePath)then
45+
File.GetLastWriteTimeUtc(resx)<= File.GetLastWriteTimeUtc(sourcePath)then
4646
printMessage(sprintf"Skipping generation: '%s' since it is up-to-date." sourcePath)
4747
Some(sourcePath)
4848
else

‎src/fsharp/FSharp.Build/FSharpEmbedResourceText.fs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ open Printf
351351
if File.Exists(outFilename)&&
352352
File.Exists(outXmlFilename)&&
353353
File.Exists(filename)&&
354-
File.GetLastWriteTime(filename)<= File.GetLastWriteTime(outFilename)&&
355-
File.GetLastWriteTime(filename)<= File.GetLastWriteTime(outXmlFilename)then
354+
File.GetLastWriteTimeUtc(filename)<= File.GetLastWriteTimeUtc(outFilename)&&
355+
File.GetLastWriteTimeUtc(filename)<= File.GetLastWriteTimeUtc(outXmlFilename)then
356356
printMessage(sprintf"Skipping generation of%s and%s since up-to-date" outFilename outXmlFilename)
357357
Some(outFilename, outXmlFilename)
358358
else

‎src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ type AsyncModule() =
162162
lettickstamps= ref[]// like timestamps but for ticks :)
163163

164164
for i=1to10do
165-
tickstamps:= DateTime.Now.Ticks::!tickstamps
165+
tickstamps:= DateTime.UtcNow.Ticks::!tickstamps
166166
do! Async.Sleep(20)
167167

168168
return!tickstamps
@@ -233,15 +233,15 @@ type AsyncModule() =
233233
[<Test>]
234234
memberthis.``AwaitWaitHandle.Timeout``()=
235235
use waitHandle=new System.Threading.ManualResetEvent(false)
236-
letstartTime= DateTime.Now
236+
letstartTime= DateTime.UtcNow
237237

238238
letr=
239239
Async.AwaitWaitHandle(waitHandle,500)
240240
|> Async.RunSynchronously
241241

242242
Assert.IsFalse(r,"Timeout expected")
243243

244-
letendTime= DateTime.Now
244+
letendTime= DateTime.UtcNow
245245
letdelta= endTime- startTime
246246
Assert.IsTrue(delta.TotalMilliseconds<1100.0, sprintf"Expected faster timeout than%.0f ms" delta.TotalMilliseconds)
247247

‎src/fsharp/vs/IncrementalBuild.fs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ module internal IncrementalBuild =
463463

464464
/// Bind a set of build rules to a set of input values.
465465
letToBound(buildRules:BuildRules,inputs:BuildInput list)=
466-
letnow= DateTime.Now
466+
letnow= DateTime.UtcNow
467467
let recapplyScalarExpr(se,results)=
468468
match sewith
469469
| ScalarInput(id, n)->
@@ -1191,7 +1191,7 @@ type IncrementalBuilder(tcGlobals, frameworkTcImports, nonFrameworkAssemblyInput
11911191
letflags,isExe= tcConfig.ComputeCanContainEntryPoint(sourceFiles|> List.map snd)
11921192
((sourceFiles, flags)||> List.map2(fun(m,nm)flag->(m, nm,(flag, isExe))))
11931193

1194-
letdefaultTimeStamp= DateTime.Now
1194+
letdefaultTimeStamp= DateTime.UtcNow
11951195

11961196
letbasicDependencies=
11971197
[for(UnresolvedAssemblyReference(referenceText,_))in unresolvedReferencesdo

‎tests/fsharpqa/Source/Conformance/DeclarationElements/CustomAttributes/AttributeUsage/AssemblyVersion03.fs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ do
77

88
letasm= System.Reflection.Assembly.GetExecutingAssembly().GetName()
99

10-
lettspan= System.TimeSpan(System.DateTime.Now.Ticks- System.DateTime(2000,1,1).Ticks)
10+
lettspan= System.TimeSpan(System.DateTime.UtcNow.Ticks- System.DateTime(2000,1,1).Ticks)
1111
letdefaultBuild=(uint16)tspan.Days% System.UInt16.MaxValue-1us
12-
letdefaultRevision=(uint16)(System.DateTime.Now.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
12+
letdefaultRevision=(uint16)(System.DateTime.UtcNow.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
1313

1414
printfn"%s"<| asm.Version.ToString()
1515
letsuccess=

‎tests/fsharpqa/Source/Conformance/DeclarationElements/CustomAttributes/AttributeUsage/AssemblyVersion04.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ do
77

88
letasm= System.Reflection.Assembly.GetExecutingAssembly().GetName()
99

10-
letdefaultRevision=(uint16)(System.DateTime.Now.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
10+
letdefaultRevision=(uint16)(System.DateTime.UtcNow.TimeOfDay.TotalSeconds/2.0)% System.UInt16.MaxValue-1us
1111

1212
printfn"%s"<| asm.Version.ToString()
1313
letsuccess=

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp