NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit38924f3

authored

Fix TypeProviders with managed resources (#5036)

* Fix TypeProviders with managed resources* Revert "Fix TypeProviders with managed resources"This reverts commit 6f925b323bbe2cf2e1a24d887cb47234389c9ef5.* Fix Type Providers still don't compile in 15.7.2 #4972

1 parent0b940a4 commit38924f3Copy full SHA for 38924f3

File tree

2 files changed

+30

-24

lines changed

src/absil
- ilread.fs
- ilwrite.fs

2 files changed

+30

-24

lines changed

`‎src/absil/ilread.fs‎`

Lines changed: 12 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3231,14 +3231,18 @@ and seekReadManifestResources (ctxt: ILMetadataReader) (mdv: BinaryView) (pectxt`
`3231`	`3231`	`letscoref= seekReadImplAsScopeRef ctxt mdv implIdx`
`3232`	`3232`
`3233`	`3233`	`letlocation=`
`3234`		`-match scorefwith`
`3235`		`-\| ILScopeRef.Local->`
`3236`		`-letstart= pectxtEager.anyV2P("resource", offset+ pectxtEager.resourcesAddr)`
`3237`		`-letresourceLength= seekReadInt32 pevEager start`
`3238`		`-letoffsetOfBytesFromStartOfPhysicalPEFile= start+4`
`3239`		`- ILResourceLocation.LocalIn(ctxt.fileName, offsetOfBytesFromStartOfPhysicalPEFile, resourceLength)`
`3240`		`-\| ILScopeRef.Module mref-> ILResourceLocation.File(mref, offset)`
`3241`		`-\| ILScopeRef.Assembly aref-> ILResourceLocation.Assembly aref`
	`3234`	`+match scorefwith`
	`3235`	`+\| ILScopeRef.Local->`
	`3236`	`+letstart= pectxtEager.anyV2P("resource", offset+ pectxtEager.resourcesAddr)`
	`3237`	`+letresourceLength= seekReadInt32 pevEager start`
	`3238`	`+letoffsetOfBytesFromStartOfPhysicalPEFile= start+4`
	`3239`	`+if pectxtEager.noFileOnDiskthen`
	`3240`	`+ ILResourceLocation.LocalOut(seekReadBytes pevEager offsetOfBytesFromStartOfPhysicalPEFile resourceLength)`
	`3241`	`+else`
	`3242`	`+ ILResourceLocation.LocalIn(ctxt.fileName, offsetOfBytesFromStartOfPhysicalPEFile, resourceLength)`
	`3243`	`+`
	`3244`	`+\| ILScopeRef.Module mref-> ILResourceLocation.File(mref, offset)`
	`3245`	`+\| ILScopeRef.Assembly aref-> ILResourceLocation.Assembly aref`
`3242`	`3246`
`3243`	`3247`	`letr=`
`3244`	`3248`	`{ Name= readStringHeap ctxt nameIdx`

`‎src/absil/ilwrite.fs‎`

Lines changed: 18 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -2682,22 +2682,24 @@ and GenEventPass3 cenv env (md: ILEventDef) =`
`2682`	`2682`
`2683`	`2683`	`let recGetResourceAsManifestResourceRow cenv r=`
`2684`	`2684`	`letdata,impl=`
`2685`		`-match r.Locationwith`
`2686`		`-\| ILResourceLocation.LocalIn_`
`2687`		`-\| ILResourceLocation.LocalOut_->`
`2688`		`-letbytes= r.GetBytes()`
`2689`		`-// Embedded managed resources must be word-aligned. However resource format is`
`2690`		`-// not specified in ECMA. Some mscorlib resources appear to be non-aligned - it seems it doesn't matter..`
`2691`		`-letoffset= cenv.resources.Position`
`2692`		`-letalignedOffset=(align0x8 offset)`
`2693`		`-letpad= alignedOffset- offset`
`2694`		`-letresourceSize= bytes.Length`
`2695`		`- cenv.resources.EmitPadding pad`
`2696`		`- cenv.resources.EmitInt32 resourceSize`
`2697`		`- cenv.resources.EmitBytes bytes`
`2698`		`- Data(alignedOffset,true),(i_File,0)`
`2699`		`-\| ILResourceLocation.File(mref, offset)-> ULong offset,(i_File, GetModuleRefAsFileIdx cenv mref)`
`2700`		`-\| ILResourceLocation.Assembly aref-> ULong0x0,(i_AssemblyRef, GetAssemblyRefAsIdx cenv aref)`
	`2685`	`+letembedManagedResources(bytes:byte[])=`
	`2686`	`+// Embedded managed resources must be word-aligned. However resource format is`
	`2687`	`+// not specified in ECMA. Some mscorlib resources appear to be non-aligned - it seems it doesn't matter..`
	`2688`	`+letoffset= cenv.resources.Position`
	`2689`	`+letalignedOffset=(align0x8 offset)`
	`2690`	`+letpad= alignedOffset- offset`
	`2691`	`+letresourceSize= bytes.Length`
	`2692`	`+ cenv.resources.EmitPadding pad`
	`2693`	`+ cenv.resources.EmitInt32 resourceSize`
	`2694`	`+ cenv.resources.EmitBytes bytes`
	`2695`	`+ Data(alignedOffset,true),(i_File,0)`
	`2696`	`+`
	`2697`	`+match r.Locationwith`
	`2698`	`+\| ILResourceLocation.LocalIn_-> embedManagedResources(r.GetBytes())`
	`2699`	`+\| ILResourceLocation.LocalOut bytes-> embedManagedResources bytes`
	`2700`	`+\| ILResourceLocation.File(mref, offset)-> ULong offset,(i_File, GetModuleRefAsFileIdx cenv mref)`
	`2701`	`+\| ILResourceLocation.Assembly aref-> ULong0x0,(i_AssemblyRef, GetAssemblyRefAsIdx cenv aref)`
	`2702`	`+`
`2701`	`2703`	`UnsharedRow`
`2702`	`2704`	`[\| data`
`2703`	`2705`	`ULong(match r.Accesswith ILResourceAccess.Public->0x01\| ILResourceAccess.Private->0x02)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit38924f3

File tree

2 files changed

2 files changed

`‎src/absil/ilread.fs‎`

`‎src/absil/ilwrite.fs‎`

0 commit comments