Commit385ee63

authored and

committed

Fix compiler crash (#3524)

1 parent02b8e09 commit385ee63Copy full SHA for 385ee63

File tree

+37

-2

lines changed

+37

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3539,14 +3539,14 @@ and`
`3539`	`3539`	`memberx.GetAssemblyName()=`
`3540`	`3540`	`match xwith`
`3541`	`3541`	`\| TType_forall(_tps, ty)-> ty.GetAssemblyName()`
`3542`		`-\| TType_app(tcref,_tinst)-> tcref.CompilationPath.ILScopeRef.AssemblyRef.QualifiedName`
	`3542`	`+\| TType_app(tcref,_tinst)-> tcref.CompilationPath.ILScopeRef.QualifiedName`
`3543`	`3543`	`\| TType_tuple(_tupInfo,_tinst)->""`
`3544`	`3544`	`\| TType_fun(_d,_r)->""`
`3545`	`3545`	`\| TType_measure_ms->""`
`3546`	`3546`	`\| TType_var tp-> tp.Solution\|>function Some sln-> sln.GetAssemblyName()\| None->""`
`3547`	`3547`	`\| TType_ucase(_uc,_tinst)->`
`3548`	`3548`	`let(TILObjectReprData(scope,_nesting,_definition))=_uc.Tycon.ILTyconInfo`
`3549`		`- scope.AssemblyRef.QualifiedName`
	`3549`	`+ scope.QualifiedName`
`3550`	`3550`
`3551`	`3551`	`andTypeInst= TType list`
`3552`	`3552`	`andTTypes= TType list`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2137,6 +2137,9 @@ module TypecheckTests =`
`2137`	`2137`	`[<Test>]`
`2138`	`2138`	let``type check neg98``()= singleNegTest(testConfig"typecheck/sigs")"neg98"
`2139`	`2139`
	`2140`	`+[<Test>]`
	`2141`	+let``type check neg99``()= singleNegTest(testConfig"typecheck/sigs")"neg99"
	`2142`	`+`
`2140`	`2143`	`[<Test>]`
`2141`	`2144`	let``type check neg_byref_1``()= singleNegTest(testConfig"typecheck/sigs")"neg_byref_1"
`2142`	`2145`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,6 @@`
	`1`	`+`
	`2`	`+neg99.fs(19,16,19,64): typecheck error FS0077: Member constraints with the name 'op_Explicit' are given special status by the F# compiler as certain .NET types are implicitly augmented with this member. This may resultin runtime failuresif you attemptto invoke the member constraint from your own code.`
	`3`	`+`
	`4`	`+neg99.fs(22,18,22,64): typecheck error FS0077: Member constraints with the name 'op_Explicit' are given special status by the F# compiler as certain .NET types are implicitly augmented with this member. This may resultin runtime failuresif you attemptto invoke the member constraint from your own code.`
	`5`	`+`
	`6`	`+neg99.fs(25,39,25,43): typecheck error FS0043: The type 'CrashFSC.OhOh.MyByte' doesnot support a conversionto the type 'CrashFSC.OhOh.MyByte'`

Lines changed: 26 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,26 @@`
	`1`	`+namespaceCrashFSC`
	`2`	`+`
	`3`	`+openSystem`
	`4`	`+`
	`5`	`+// debatable code, but it was the minimalist example I could come up`
	`6`	`+// with after analysis in the original project`
	`7`	`+moduleOhOh=`
	`8`	`+`
	`9`	`+typeMyByte= MyByteofbytewith`
	`10`	`+static member inlineop_Explicit(MyByte x):int64= int64 x`
	`11`	`+static member inlineop_Explicit(MyByte x):double= double x`
	`12`	`+`
	`13`	`+static member inlineop_Explicit(x:int64):MyByte= MyByte(byte x)`
	`14`	`+static member inlineop_Explicit(x:float):MyByte= MyByte(byte x)`
	`15`	`+static member inlineop_Explicit(MyByte x):'a= failwith"cannot convert"`
	`16`	`+`
	`17`	`+/// testing testing`
	`18`	`+let inline(!>>>)(a:^a)min:^b option=`
	`19`	`+if a<(^b:(static memberop_Explicit:^b->^a) min)`
	`20`	`+then None`
	`21`	`+else`
	`22`	`+ Some(^b:(static memberop_Explicit:^a->^b) a)`
	`23`	`+`
	`24`	`+let inlinecrashMe(a:^a)min=`
	`25`	`+let(result:MyByte option)=!>>> a min`
	`26`	`+ result`

Comments

(0)