Commit34e669c

authored

Fix stack overflow on assembly resolution (#3658)

* Fix stack overflow on tp assembly resolution* Feedback

1 parent780b6c4 commit34e669cCopy full SHA for 34e669c

File tree

-1

lines changed

-1

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,15 @@ module internal ReflectionAdapters =`
`327`	`327`	`overridethis.Load(assemblyName:AssemblyName):Assembly=`
`328`	`328`	`this.LoadFromAssemblyName(assemblyName)`
`329`	`329`
`330`		`-letglobalLoadContext=new CustomAssemblyResolver()`
	`330`	`+letglobalLoadContext=`
	`331`	`+// This is an unfortunate temporary fix!!!!`
	`332`	`+// ========================================`
	`333`	`+// We need to run fsi tests on a very old version of the corclr because of an unfortunate test framework`
	`334`	`+// This hack detects that, and uses the old code.`
	`335`	`+// On slightly newer code AssemblyLoadContext.Default is the way to go.`
	`336`	`+match Seq.tryHead(typeof<RuntimeTypeHandle>.GetTypeInfo().Assembly.GetCustomAttributes<AssemblyFileVersionAttribute>())with`
	`337`	`+\| Some awhen a.Version="4.6.24410.01"->new CustomAssemblyResolver():> AssemblyLoadContext`
	`338`	`+\|_-> AssemblyLoadContext.Default`
`331`	`339`
`332`	`340`	`#endif`
`333`	`341`	`typeSystem.Reflection.Assemblywith`

Comments

(0)