Commit2db96a1

authored and

committed

IsFSharpInterfaceTycon shouldn't be asked multiple times (#4974)

1 parent4eed66b commit2db96a1Copy full SHA for 2db96a1

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,8 @@ type Checker(g, amap, denv, remapInfo: SignatureRepackageInfo, checkingSig) =`
`183`	`183`	`letunimpl= ListSet.subtract(fun fity aity-> typeAEquiv g aenv aity fity) fintfs aintfs`
`184`	`184`	`(unimpl\|> List.forall(fun ity-> errorR(Error(FSComp.SR.DefinitionsInSigAndImplNotCompatibleMissingInterface(implTycon.TypeOrMeasureKind.ToString(),implTycon.DisplayName, NicePrint.minimalStringOfType denv ity),m));false))&&`
`185`	`185`	`lethidden= ListSet.subtract(typeAEquiv g aenv) aintfsUser fintfs`
`186`		`- hidden\|> List.iter(fun ity->(if implTycon.IsFSharpInterfaceTyconthen errorelse warning)(InterfaceNotRevealed(denv,ity,implTycon.Range)))`
	`186`	`+letwarningOrError=if implTycon.IsFSharpInterfaceTyconthen errorelse warning`
	`187`	`+ hidden\|> List.iter(fun ity-> warningOrError(InterfaceNotRevealed(denv,ity,implTycon.Range)))`
`187`	`188`
`188`	`189`	`letaNull= IsUnionTypeWithNullAsTrueValue g implTycon`
`189`	`190`	`letfNull= IsUnionTypeWithNullAsTrueValue g sigTycon`

Comments

(0)