You signed in with another tab or window.Reload to refresh your session.You signed out in another tab or window.Reload to refresh your session.You switched accounts on another tab or window.Reload to refresh your session.Dismiss alert
<MonoPathCondition="'$(MonoPath)' == '' And Exists('/Library/Frameworks/Mono.framework/Commands/mono')">/Library/Frameworks/Mono.framework/Commands/mono</MonoPath>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+23-23Lines changed: 23 additions & 23 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,19 +1,19 @@
1
-
##Contribution Guidelines
1
+
##Contribution Guidelines
2
2
3
3
The Visual F# team is proud to be a contributor to F#, and urge you to join in too. F# users and the F# community are grateful for all contributions to F#.
4
4
5
5
Besides this overview, we recommend["Becoming a contributor"](http://mrange.wordpress.com/2014/12/11/becoming-an-fsharp-contributor/), a community blog post by Mårten Rånge.
6
6
For those contributing to the core of the F# compiler, we recommend["The F# Compiler Technical Overview"](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html)
-Read howto run testsin[TESTGUIDE.md](TESTGUIDE.md)
15
15
16
-
###What to Contribute?
16
+
###What to Contribute?
17
17
18
18
There are several important ways that you can contribute. We are especially grateful for early feedback on in-development features, bug reports with repro steps, bug fixes with regression test cases, cross-platform expertise and changes, documentation updates, feature tests, suggestions, comments, and ideas.
19
19
@@ -26,27 +26,27 @@ We initially solicit contributions for
26
26
- library improvements
27
27
- F# language and library features
28
28
29
-
New features are welcome, but be aware that Visual F# is a high-quality programming language with high-quality tools, and we wish to keep it that way. Before embarking on an extensive feature implementation, make a proposal in a GitHub issue or on the[F# LanguageUserVoice](https://fslang.uservoice.com/) so the community can review and comment on it.
29
+
New features are welcome, but be aware that Visual F# is a high-quality programming language with high-quality tools, and we wish to keep it that way. Before embarking on an extensive feature implementation, make a proposal in a GitHub issue or on the[F# LanguageSuggestions](https://github.com/fsharp/fslang-suggestions) so the community can review and comment on it.
30
30
31
31
###Issues
32
32
33
33
When submitting issues, please use the following guidelines
34
34
35
-
- Suggestions for the F# Language and Core library should be added and reviewed at the[F# LanguageUser Voice](https://fslang.uservoice.com/).
35
+
- Suggestions for the F# Language and Core library should be added and reviewed at the[F# LanguageSuggestions](https://github.com/fsharp/fslang-suggestions).
36
36
37
-
- Suggestions for the Visual F# Tools should be added and reviewed at the[Visual Studio F# Tools User Voice](https://visualstudio.uservoice.com/forums/121579-visual-studio/category/30935-languages-f-tools).
37
+
- Suggestions for the Visual F# Tools should be added and reviewed at the[Visual Studio F# ToolsGitHub](https://github.com/microsoft/visualfsharp).
38
38
39
39
- New Bug Reports should always give accurate, clear steps for reproducing the bug, and all relevant details about versions, platform, etc. We suggest the following template:
40
40
41
-
Title:<a short, clear title>
41
+
Title:<a short, clear title>
42
42
43
-
Description:<adescriptionoftheproblem>
43
+
Description:<a description of the problem>
44
44
45
-
Repro Steps:<stepbystepdescription>
45
+
Repro Steps:<step by step description>
46
46
47
-
Expected:<whatisexpected>
47
+
Expected:<what is expected>
48
48
49
-
Actual:<whatyoureallyget>
49
+
Actual:<what you really get>
50
50
51
51
Severity: a description on how bad it is and why - is it blocking?
52
52
@@ -58,11 +58,11 @@ When submitting issues, please use the following guidelines
58
58
59
59
Workaround: List any known workarounds
60
60
61
-
###CLA
61
+
###CLA
62
62
63
63
Contributors are required to sign a[Contribution License Agreement](https://cla.microsoft.com/) (CLA) before any pull requests will be considered. After submitting a request via the provided form, electronically sign the CLA when you receive the email containing the link to the document. This only needs to be done once for each Microsoft OSS project you contribute to.
64
64
65
-
###Quality and Testing
65
+
###Quality and Testing
66
66
67
67
Contributions to this repository will be rigorously policed for quality.
68
68
@@ -109,26 +109,26 @@ Bug fix PRs have the following minimum requirements
109
109
110
110
Feature PRs have the following minimum requirements:
111
111
112
-
- For F# Language and Library features, include a link to the[F# LanguageUser Voice](http://fslang.uservoice.com)
112
+
- For F# Language and Library features, include a link to the[F# LanguageSuggestions](https://github.com/fsharp/fslang-suggestions) issue
113
113
114
-
- For Visual F# Tools features, include a link to the[Visual F# Tools User Voice](https://visualstudio.uservoice.com/forums/121579-visual-studio/category/30935-languages-f-tools) entry for the feature.
114
+
- For Visual F# Tools features, include a link to the[Visual F# Tools](https://github.com/microsoft/visualfsharp) issue for the feature.
115
115
116
116
- For F# Library features, if you have made additions to the FSharp.Core library public surface area, update[the SurfaceArea tests](https://github.com/Microsoft/visualfsharp/tree/fsharp4/src/fsharp/FSharp.Core.Unittests).
117
117
118
-
- For F# Language and Library features, you will be asked to submit a speclet for the feature to the[F# Language Design](https://github.com/fsharp/FSharpLangDesign/) GitHub repository of speclets. In some cases you will only need to do this after your feature is accepted, but for more complex features you may be asked to do this during the review of the feature.
118
+
- For F# Language and Library features, you will be asked to submit a speclet for the feature to the[F# Language Design](https://github.com/fsharp/fslang-design) GitHub repository of speclets. In some cases you will only need to do this after your feature is accepted, but for more complex features you may be asked to do this during the review of the feature.
119
119
120
120
- Language feature implementations must take into account the expectations of typical users about the performance
121
121
impact of using the feature. For example, we should avoid the situation where using an optional language feature
122
122
which appears benign to a typical user has a large negative performance impact on code.
123
123
124
124
- Language feature implementations should not cause performance degradation in existing code.
125
125
126
-
###Language Evolution
126
+
###Language Evolution
127
127
128
128
We are committed to carefully managing the evolution of the F# language.
129
129
130
-
We actively solicit contributions related to the F# language design, but the process for handling these differs substantially from other kinds of contributions. Significant language and library change should be suggested and reviewed at the[F# LanguageUser Voice](https://fslang.uservoice.com/) site.
130
+
We actively solicit contributions related to the F# language design, but the process for handling these differs substantially from other kinds of contributions. Significant language and library change should be suggested and reviewed at the[F# LanguageSuggestions](https://github.com/fsharp/fslang-suggestions) repository.
131
131
132
-
###Coding guidelines
132
+
###Coding guidelines
133
133
134
134
Although there is currently no strict set of coding or style guidelines, use common sense when contributing code - make an effort to use a similar style to nearby existing code. If you have a passion for helping us develop a set of coding guidelines that we can roll out and apply within this project, get involved and start a discussion issue.
Copy file name to clipboardExpand all lines: DEVGUIDE.md
+17-11Lines changed: 17 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -105,33 +105,41 @@ Where you should set proper proxy address, user name and password.
105
105
106
106
#The Visual F# IDE Tools (Windows Only)
107
107
108
-
To build and test Visual F# IDE Tools, you must use the latest version of[Visual Studio 2017 RC](https://www.visualstudio.com/vs/visual-studio-2017-rc/#downloadvs). See the section titled "Development tools" in the[readme](README.md).
108
+
To build and test Visual F# IDE Tools, you must use the latest version of[Visual Studio 2017](https://www.visualstudio.com/downloads/). See the section titled "Development tools" in the[readme](README.md).
109
109
110
110
build.cmd vs -- build the Visual F# IDE Tools (see below)
111
111
build.cmd vs test -- build Visual F# IDE Tools, run all tests (see below)
112
112
113
113
Use``VisualFSharp.sln`` if you're building the Visual F# IDE Tools.
114
114
115
+
Note: if you face this error[#2351](https://github.com/Microsoft/visualfsharp/issues/2351):
116
+
117
+
> error VSSDK1077: Unable to locate the extensions directory. "ExternalSettingsManager::GetScopePaths failed to initialize PkgDefManager for C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe".
118
+
119
+
Or hard crash on launch ("Unknown Error"), delete these folders:
120
+
121
+
*`%localappdata%\Microsoft\VisualStudio\15.0_(some number here)FSharpDev`
122
+
*`%localappdata%\Microsoft\VisualStudio\15.0_(some number here)`
115
123
116
124
##[Optional] Install the Visual F# IDE Tools (Windows Only)
117
125
118
126
At time of writing, the Visual F# IDE Tools can only be installed into the latest Visual Studio 2017 RC releases.
119
127
The new builds of the Visual F# IDE Tools can no longer be installed into Visual Studio 2015.
120
128
121
-
You can install Visual Studio 2017RCfromhttps://www.visualstudio.com/vs/visual-studio-2017-rc/#downloadvs.
129
+
You can install Visual Studio 2017 fromhttps://www.visualstudio.com/downloads/.
122
130
123
131
**Note:** This step will install a VSIX extension into Visual Studio "Next" that changes the Visual F# IDE Tools
124
132
components installed in that VS installation. You can revert this step by disabling or uninstalling the addin.
Restart Visual Studio, it should now be running your freshly-built Visual F# IDE Tools with updated F# Interactive.
137
145
@@ -151,17 +159,15 @@ This gives a much tighter inner development loop than uninstalling/reinstalling
151
159
152
160
###[Optional] Clobber the F# SDK on the machine
153
161
154
-
**Note:**Step#3 below will clobber the machine-wide installed F# SDK on your machine. This replaces the``fsi.exe``/``fsiAnyCpu.exe`` used byVisual F# Interactive and the``fsc.exe`` used by``Microsoft.FSharp.targets``. Repairing Visual Studio 15 is currently the only way to revert this step.
162
+
**Note:**The step below willtry toclobber the machine-wide installed F# SDK on your machine. This replaces the``fsc.exe`` used bythe standard innstall location or``Microsoft.FSharp.targets``.**Repairing Visual Studio 15 is currently the only way to revert this step.**
155
163
156
164
For**Debug**:
157
165
158
-
1. Run``vsintegration\update-vsintegration.cmd debug`` (clobbers the installed F# SDK)
166
+
vsintegration\update-vsintegration.cmd debug
159
167
160
168
For**Release**:
161
169
162
-
1. Run``vsintegration\update-vsintegration.cmd release`` (clobbers the installed F# SDK)