Commit1d5a782

authored and

committed

Do not show "rename unused declaration" code fix on functions and methods (#4094)

* do not show "rename unused declaration" code fix on functions and methods* IsFunctionOrMember -> IsValue

1 parent6d3f6de commit1d5a782Copy full SHA for 1d5a782

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1806,6 +1806,11 @@ and FSharpMemberOrFunctionOrValue(cenv, d:FSharpMemberOrValData, item) =`
`1806`	`1806`	`\| V valRef-> IlxGen.IsValCompiledAsMethod cenv.g valRef.Deref`
`1807`	`1807`	`\|_->false`
`1808`	`1808`
	`1809`	`+memberx.IsValue=`
	`1810`	`+match dwith`
	`1811`	`+\| V valRef->not(SymbolHelpers.isFunction cenv.g valRef.Type)`
	`1812`	`+\|_->false`
	`1813`	`+`
`1809`	`1814`	`overridex.Equals(other:obj)=`
`1810`	`1815`	`box x=== other\|\|`
`1811`	`1816`	`match otherwith`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -883,6 +883,9 @@ and [<Class>] internal FSharpMemberOrFunctionOrValue =`
`883`	`883`
`884`	`884`	`/// Indicated if this is a value compiled to a method`
`885`	`885`	`memberIsValCompiledAsMethod:bool`
	`886`	`+`
	`887`	`+/// Indicated if this is a value`
	`888`	`+memberIsValue:bool`
`886`	`889`
`887`	`890`	`/// Indicates if this is a constructor.`
`888`	`891`	`memberIsConstructor:bool`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ type internal FSharpRenameUnusedValueCodeFixProvider`
`69`	`69`
`70`	`70`	`if func.IsMemberThisValuethen`
`71`	`71`	`createCodeFix(context, symbolName, SR.RenameValueToDoubleUnderscore(), TextChange(context.Span,"__"))`
`72`		`-elifnotfunc.IsMemberthen`
	`72`	`+elif func.IsValuethen`
`73`	`73`	`createCodeFix(context, symbolName, SR.RenameValueToUnderscore(), TextChange(context.Span,"_"))`
`74`	`74`	`\|_->()`
`75`	`75`	`}`

Comments

(0)