Commit0c88694

authored and

committed

fix generalization of top-level value that uses a mutable top-level binding (#3389)

1 parent938da3e commit0c88694Copy full SHA for 0c88694

File tree

+19

-0

lines changed

+19

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2120,9 +2120,11 @@ module GeneralizationHelpers =`
`2120`	`2120`	`&& List.forall (IsGeneralizableValue g) args`
`2121`	`2121`
`2122`	`2122`	`\| Expr.LetRec(binds,body,_,_) ->`
	`2123`	`+ binds \|> List.forall (fun b -> not b.Var.IsMutable) &&`
`2123`	`2124`	`binds \|> List.forall (fun b -> IsGeneralizableValue g b.Expr) &&`
`2124`	`2125`	`IsGeneralizableValue g body`
`2125`	`2126`	`\| Expr.Let(bind,body,_,_) ->`
	`2127`	`+ not bind.Var.IsMutable &&`
`2126`	`2128`	`IsGeneralizableValue g bind.Expr &&`
`2127`	`2129`	`IsGeneralizableValue g body`
`2128`	`2130`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -625,6 +625,23 @@ module BasicPermutations =`
`625`	`625`	`// to the base implementations of overridden members <file> <line>`
`626`	`626`	`overridex.Foo a=base.Foo(a)`
`627`	`627`
	`628`	`+moduleTest2=`
	`629`	`+lettag=`
	`630`	`+let mutablei=0`
	`631`	`+fun _-> i<- i+1; i// this should _not_ generalize, see https://github.com/Microsoft/visualfsharp/issues/3358`
	`632`	`+`
	`633`	`+ test"vwekjwve91"(tag())1`
	`634`	`+ test"vwekjwve92"(tag())2`
	`635`	`+ test"vwekjwve93"(tag())3`
	`636`	`+`
	`637`	`+moduleTest3=`
	`638`	`+let rectag=`
	`639`	`+let mutablei=0`
	`640`	`+fun _-> i<- i+1; i// this should _not_ generalize, see https://github.com/Microsoft/visualfsharp/issues/3358`
	`641`	`+`
	`642`	`+ test"vwekjwve94"(tag())1`
	`643`	`+ test"vwekjwve95"(tag())2`
	`644`	`+ test"vwekjwve96"(tag())3`
`628`	`645`
`629`	`646`	`#if TESTS_AS_APP`
`630`	`647`	`letRUN()=!failures`

Comments

(0)