Commit0676848

Vasily Kirichenko

authored and

Vasily Kirichenko

committed

do not use MembersFunctionsAndValues

1 parentd225014 commit0676848Copy full SHA for 0676848

File tree

+19

-4

lines changed

+19

-4

lines changed

Lines changed: 15 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,21 @@ module UnusedOpens =`
`126`	`126`	`modulGroup.Modules`
`127`	`127`	`\|> List.exists(fun modul->`
`128`	`128`	`symbolUsesInScope`
`129`		`-\|> Array.exists(fun symbolUse->`
`130`		`- modul.ChildSymbols`
`131`		`-\|> Seq.exists(fun x-> x.IsEffectivelySameAs symbolUse.Symbol))))`
	`129`	`+\|> Array.exists(fun symbolUse->`
	`130`	`+match symbolUse.Symbolwith`
	`131`	`+\|:? FSharpMemberOrFunctionOrValueas f->`
	`132`	`+match f.EnclosingEntitywith`
	`133`	`+\| Some enclosingEntity-> enclosingEntity.IsEffectivelySameAs modul.Entity`
	`134`	`+\|_->false`
	`135`	`+\|_->false`
	`136`	`+//\| :? FSharpEntity as ent ->`
	`137`	`+// match ent. EnclosingEntity with`
	`138`	`+// \| Some enclosingEntity -> enclosingEntity.IsEffectivelySameAs modul.Entity`
	`139`	`+// \| _ -> false`
	`140`	`+`
	`141`	`+//modul.ChildSymbols`
	`142`	`+//\|> Seq.exists (fun x -> x.IsEffectivelySameAs symbolUse.Symbol))))`
	`143`	`+)))`
`132`	`144`	`\|> List.collect(fun mg->`
`133`	`145`	`mg.Modules\|> List.map(fun x->{ Module= x.Entity; AppliedScope= openStatement.AppliedScope}))`
`134`	`146`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,10 @@ type internal UnusedOpensDiagnosticAnalyzer() =`
`43`	`43`	`do! Option.guard Settings.CodeFixes.UnusedOpens`
`44`	`44`	`let!sourceText= document.GetTextAsync()`
`45`	`45`	`let!_,_,checkResults= checker.ParseAndCheckDocument(document, options, sourceText= sourceText, allowStaleResults=true, userOpName= userOpName)`
`46`		`-return! UnusedOpens.getUnusedOpens(checkResults,fun lineNumber-> sourceText.Lines.[Line.toZ lineNumber].ToString())\|> liftAsync`
	`46`	`+letsw= Stopwatch.StartNew()`
	`47`	`+let!unusedOpens= UnusedOpens.getUnusedOpens(checkResults,fun lineNumber-> sourceText.Lines.[Line.toZ lineNumber].ToString())\|> liftAsync`
	`48`	`+ Logging.Logging.logInfof"*** Got%d unused opens in%O" unusedOpens.Length sw.Elapsed`
	`49`	`+return unusedOpens`
`47`	`50`	`}`
`48`	`51`
`49`	`52`	`overridethis.AnalyzeSemanticsAsync(document:Document,cancellationToken:CancellationToken)=`

Comments

(0)