Commitfd49ca7

authored and

Felipe Zimmerle

committed

Don't leak an fd on fuzzy hash initialization

Since we're re-opening this file with every invocation, let'sclose our sanity check fd.

1 parent6cce8a2 commitfd49ca7Copy full SHA for fd49ca7

File tree

-3

lines changed

-3

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3828,6 +3828,7 @@ static int msre_op_fuzzy_hash_init(msre_rule rule, char *error_msg)`
`3828`	`3828`	`{`
`3829`	`3829`	`#ifdefWITH_SSDEEP`
`3830`	`3830`	`structfuzzy_hash_param_data*param_data;`
	`3831`	`+FILE*fp;`
`3831`	`3832`	`char*file;`
`3832`	`3833`	`intparam_len,threshold;`
`3833`	`3834`
`@@ -3876,14 +3877,15 @@ static int msre_op_fuzzy_hash_init(msre_rule rule, char *error_msg)`
`3876`	`3877`	`}`
`3877`	`3878`
`3878`	`3879`	`file=resolve_relative_path(rule->ruleset->mp,rule->filename,file);`
`3879`		`-`
`3880`		`-if (!fopen(file,"r"))`
	`3880`	`+`
	`3881`	`+fp=fopen(file,"r");`
	`3882`	`+if (!fp)`
`3881`	`3883`	`{`
`3882`	`3884`	`*error_msg=apr_psprintf(rule->ruleset->mp,"Not able to open file:" \`
`3883`	`3885`	`" %s.",file);`
`3884`	`3886`	`return-1;`
`3885`	`3887`	`}`
`3886`		`-`
	`3888`	`+fclose(fp);`
`3887`	`3889`
`3888`	`3890`	`param_data->file=file;`
`3889`	`3891`	`param_data->threshold=threshold;`

Comments

(0)