Commit1980322

Felipe Zimmerle

committed

Improvesowasp-modsecurity#927 by checking earlier if the string is empty or not

1 parent7ba07bd commit1980322Copy full SHA for 1980322

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -626,8 +626,10 @@ int collections_remove_stale(modsec_rec msr, const char col_name) {`
`626`	`626`	`*/`
`627`	`627`	`rc=apr_sdbm_firstkey(dbm,&key);`
`628`	`628`	`while(rc==APR_SUCCESS) {`
`629`		`-char*s=apr_pstrmemdup(msr->mp,key.dptr,strlen(key.dptr));`
`630`		`-(char*)apr_array_push(keys_arr)=s;`
	`629`	`+if (key.dsize) {`
	`630`	`+char*s=apr_pstrmemdup(msr->mp,key.dptr,key.dsize-1);`
	`631`	`+(char*)apr_array_push(keys_arr)=s;`
	`632`	`+ }`
`631`	`633`	`rc=apr_sdbm_nextkey(dbm,&key);`
`632`	`634`	`}`
`633`	`635`	`apr_sdbm_unlock(dbm);`

Comments

(0)