Commite4ec979

authored

Prompt users to run pre-commit when detecting ruff failures (stanfordnlp#8338)

* add ruff hint* use single quote* revert testing changes

1 parentb30c55c commite4ec979Copy full SHA for e4ec979

File tree

+13

-3

lines changed

+13

-3

lines changed

Lines changed: 12 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,18 @@ jobs:`
`32`	`32`	`echo "${{ github.workspace }}/.venv/bin" >> $GITHUB_PATH`
`33`	`33`	`-name:Install dependencies`
`34`	`34`	`run:uv sync --dev -p .venv --extra dev`
`35`		`- -name:Ruff Fix Attempt`
`36`		`-id:ruff_fix`
`37`		`-run:ruff check --fix-only --diff --exit-non-zero-on-fix`
	`35`	`+ -name:Ruff Check`
	`36`	`+run:\|`
	`37`	`+ ruff check --fix-only --diff --exit-non-zero-on-fix \|\| (`
	`38`	`+ echo ""`
	`39`	`+ echo "❌ Ruff found issues that can be fixed automatically."`
	`40`	`+ echo "💡 To fix them locally, run:"`
	`41`	`+ echo ""`
	`42`	`+ echo " pre-commit run --all-files"`
	`43`	`+ echo ""`
	`44`	`+ echo "Then commit and push the changes."`
	`45`	`+ exit 1`
	`46`	`+ )`
`38`	`47`
`39`	`48`	`test:`
`40`	`49`	`name:Run Tests`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ def __init__(`
`30`	`30`	`disk_cache_dir:str,`
`31`	`31`	`disk_size_limit_bytes:Optional[int]=1024102410,`
`32`	`32`	`memory_max_entries:Optional[int]=1000000,`
	`33`	`+`
`33`	`34`	`):`
`34`	`35`	`"""`
`35`	`36`	`Args:`

Comments

(0)