NotificationsYou must be signed in to change notification settings
Fork239
Star1.2k

Commitf454e23

authored

Fix a CMake warning on release builds

It looks like this isn't a regression - all previous releases had thisissue. We simply didn't use the "-Werror=dev" flag before when testingCMake. If the "pcre2_prerelease" variable was set to empty string, itwould be treated as "falsy" by CMake and not substituted correctly.

1 parentb0b6ebb commitf454e23Copy full SHA for f454e23

File tree

1 file changed

-4

lines changed

CMakeLists.txt

1 file changed

-4

lines changed

`‎CMakeLists.txt‎`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -733,10 +733,9 @@ set(`
`733`	`733`	`foreach(configure_line${configure_lines})`
`734`	`734`	`foreach(substitution_variable${SEARCHED_VARIABLES})`
`735`	`735`	`string(TOUPPER${substitution_variable} substitution_variable_upper)`
`736`		`- if(NOT${substitution_variable_upper})`
`737`		`- string(REGEX MATCH"m4_define\\(${substitution_variable}, \\[(.)\\]" MATCHED_STRING${configure_line})`
`738`		`- if(CMAKE_MATCH_1)`
`739`		`- set(${substitution_variable_upper}${CMAKE_MATCH_1})`
	`736`	`+ if(NOTDEFINED${substitution_variable_upper})`
	`737`	`+ if("${configure_line}"MATCHES"m4_define\\(${substitution_variable}, \\[(.)\\]")`
	`738`	`+ set(${substitution_variable_upper}"${CMAKE_MATCH_1}")`
`740`	`739`	`endif()`
`741`	`740`	`endif()`
`742`	`741`	`endforeach()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf454e23

File tree

1 file changed

1 file changed

`‎CMakeLists.txt‎`

0 commit comments