- Notifications
You must be signed in to change notification settings - Fork275
[WIP] Fix material deserialization assertion when creating new projects#606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intomainChoose a base branch fromcopilot/fix-aef0d10f-8391-4091-a8d9-48aee48bcb1a
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: adriengivry <33324216+adriengivry@users.noreply.github.com>
Co-authored-by: adriengivry <33324216+adriengivry@users.noreply.github.com>
CopilotAI changed the title[WIP] [ASSERT] Attempting to SetProperty on a non-existing propertyFix material deserialization assertion when creating new projectsOct 2, 2025
Copilot finished work on behalf ofadriengivryOctober 2, 2025 20:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
When creating a new project in OvEditor, users would encounter an assertion error:
This caused the editor to display a white screen and prevented normal project creation.
Root Cause
The issue occurred during material deserialization in
OvCore::Resources::Material::OnDeserialize(). The deserialization process:SetShader()to populate material properties from shader uniformsSetProperty()The
SetProperty()method has an assertion that fails if the property doesn't exist. This can happen when:Solution
Replaced all
SetProperty()calls withTrySetProperty()in the deserialization visitor. TheTrySetProperty()method:trueif successful,falseif the property doesn't existThis provides graceful handling of property mismatches between serialized materials and their current shaders, which is expected behavior during version updates or shader changes.
Changes
Sources/Overload/OvCore/src/OvCore/Resources/Material.cppSetProperty()toTrySetProperty()This is a minimal, defensive fix that maintains backwards compatibility while preventing assertions during normal editor operations.
Fixes #<issue_number>
Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.