- Notifications
You must be signed in to change notification settings - Fork517
Clang tidy#1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
uqs wants to merge4 commits intoOpenXcom:masterChoose a base branch fromuqs:clang-tidy
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Clang tidy#1286
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is in addition to generating Makefiles or Ninja files. It can beused by various LLVM tooling like clang-tidy or YouCompleteMe
Ran: clang-tidy -p . -header-filter=".*" "-checks=-*,performance-inefficient-string-concatenation" -fix **/*.cppTo solve: warning: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation]
floor(3) as used previously is the libc floor, which takes a doublealways, so the cast to float is superfluous. floorf(3) would take afloat argument, but instead of switching to that, use std::floor whichhas the proper overload for double/float, and as of C++11 also has onefor integral types, so use that directly.The clang-tidy fixes were massaged manually, as it wasn't quite assmart.
The fixes that added std::move (C++11 only) were manually revertedagain. This sprinkles a ton of const refs all over the place, obviatingthe need to copy-construct Position all the time.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various clang-tidy inspired cleanups, they shrink the binary size by about 4k :)
They should speed things up as the Position ctor will be called less often.
I'm a bit surprised about the float math though, sure on a i386 it was faster than double math, but these days?