NotificationsYou must be signed in to change notification settings
Fork147
Star286

check if shared_ciphers() is None before logging#700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

arp102 merged 1 commit intoOpenKMIP:masterfromkevinAlbs:check-for-none

Aug 1, 2023

Merged

check if shared_ciphers() is None before logging#700

arp102 merged 1 commit intoOpenKMIP:masterfromkevinAlbs:check-for-none

Aug 1, 2023

Conversation

Copy link

Contributor

kevinAlbs commentedJun 23, 2023

Summary

Check forNone return inssl.SSLSocket.shared_ciphers()

Background & Motivation

This is motivated by an observed exception in the PyKMIP server logs:

2023-06-21 19:35:58,173 - kmip.server.session.00000003 - WARNING - Failure parsing request message.2023-06-21 19:35:58,173 - kmip.server.session.00000003 - ERROR - object of type 'NoneType' has no len()Traceback (most recent call last):  File "/data/mci/ed2138b4a01580ba489bb7e3b9bc6679/drivers-tools/.evergreen/csfle/kmstlsvenv/lib/python3.11/site-packages/kmip/services/server/session.py", line 133, in _handle_message_loop    "Possible session ciphers: {0}".format(len(shared_ciphers))                                           ^^^^^^^^^^^^^^^^^^^TypeError: object of type 'NoneType' has no len()

shared_ciphersis documented as possibly returningNone: