Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Onesignal export typescript created#822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
joazco wants to merge1 commit intoOneSignal:main
base:main
Choose a base branch
Loading
fromjoazco:create-onesignal-export-typescript

Conversation

joazco
Copy link

@joazcojoazco commentedNov 16, 2022
edited by niels-s
Loading

Description

One Line Summary

I created a Onesignal.ts file in order to use the plugin in a cordova project in typescript

Details

Motivation

My motivation is to be able to code cordova in typescript

Checklist

Overview

  • I have filled out allREQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawbyemawby requested a review fromnan-liJanuary 24, 2023 21:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nan-linan-liAwaiting requested review from nan-li

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joazco

[8]ページ先頭

©2009-2025 Movatter.jp