Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix rocket.surgery.nuke Update#1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JoeRobich wants to merge10 commits intomaster
base:master
Choose a base branch
Loading
fromdev/jorobich/fixup-1336

Conversation

JoeRobich
Copy link
Member

Fix up#1336

  • Mimic the style of the RSG/Nuke repo's .build
  • Regenerated GH actions
  • Left in the tweaks around NuGet caching, the matrix of artifacts, and NuGet publishing

@github-actionsgithub-actionsbot added this to thev0.19.10 milestoneFeb 4, 2025
- Mimic the style of the RSG/Nuke repo's .build- Regenerated GH actions- Left in the tweak around NuGet caching, the matrix of artifacts, and NuGet publishing
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedFeb 4, 2025•
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commita7202f7.

♻️ This comment has been updated with latest results.

@JoeRobich
Copy link
MemberAuthor

Reviewing the CI logs it appears to be having trouble locating the test results and code coverage. Need to investigate further.

@manandre
Copy link
Contributor

I have found a possible explanation inside build logs:

[INF] "/home/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverlet.runsettings" is not a valid Coverage settings file. Using default values.

But I do not see which part is considered as invalid.

@manandre
Copy link
Contributor

Solution found!
The DataCollector must be namedcode coverage and notXPlat code coverage.

JoeRobich reacted with thumbs up emoji

@github-actionsGitHub Actions
Copy link

Summary

Summary
Generated on:2/9/2025 - 12:00:39 AM
Coverage date:2/9/2025 - 12:00:38 AM
Parser:Cobertura
Assemblies:0
Classes:0
Files:0
Line coverage:
Covered lines:0
Uncovered lines:0
Coverable lines:0
Total lines:0
Covered branches:0
Total branches:0
Method coverage:Feature is only available for sponsors
Tag:0.19.10-PullRequest1449.510+Branch.pull-1449-merge.Sha.a9a325e63b093e7c42512271baf5ffc751041f01

Coverage

No assemblies have been covered.

@JoeRobich
Copy link
MemberAuthor

JoeRobich commentedFeb 9, 2025•
edited
Loading

Maybe it doesn't like the relative paths
image
from the logs

2025-02-08T23:58:55.7518600Z [INF] Starting test execution, please wait...2025-02-08T23:58:55.8026940Z [INF] A total of 1 test files matched the specified pattern.2025-02-08T23:58:56.1031980Z [INF] [xUnit.net 00:00:01.37]     JsonRpc.Tests.HandlerResolverTests.Should_Have_CorrectParams [SKIP]2025-02-08T23:58:56.1063840Z [INF] [xUnit.net 00:00:01.37]     JsonRpc.Tests.HandlerResolverTests.Should_Contain_AllDefinedMethods [SKIP]2025-02-08T23:58:56.1270350Z [INF]   Skipped JsonRpc.Tests.HandlerResolverTests.Should_Have_CorrectParams [1 ms]2025-02-08T23:58:56.1385180Z [INF]   Skipped JsonRpc.Tests.HandlerResolverTests.Should_Contain_AllDefinedMethods [1 ms]2025-02-08T23:58:58.4653570Z [INF] Results File: /Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/artifacts/test/_Mac-1739056916847_2025-02-08_23_58_57.trx2025-02-08T23:58:58.4761190Z [INF] 2025-02-08T23:58:58.4863110Z [INF] Passed!  - Failed:     0, Passed:     8, Skipped:     0, Total:     8, Duration: 1 s - OmniSharp.Extensions.LanguageClient.Tests.dll (net8.0)2025-02-08T23:58:58.4925490Z [INF]   [coverlet] 2025-02-08T23:58:58.5026360Z [INF]   Calculating coverage result...2025-02-08T23:58:58.5384890Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.json'2025-02-08T23:58:58.5408980Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.info'2025-02-08T23:58:58.5421430Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.cobertura.xml'2025-02-08T23:58:58.5474940Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.opencover.xml'

@manandre
Copy link
Contributor

manandre commentedFeb 9, 2025•
edited
Loading

Surprising. The previous step is also using a relative pathartifacts/logs/ and seems to work correctly.

@JoeRobichJoeRobich marked this pull request as draftFebruary 11, 2025 08:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19.10
Development

Successfully merging this pull request may close these issues.

2 participants
@JoeRobich@manandre
[8]ページ先頭
©2009-2025 Movatter.jp