backend/apps/core/validators.py (1)

90-95:🛠️ Refactor suggestion

Update the error message to match the new validation pattern.

The regex pattern has been properly updated to^[\w .-]*$ to allow word characters, spaces, periods, and hyphens. However, the error message still only mentions "alphanumeric characters, hyphens, spaces, and underscores" without including periods (.) and the fact that word characters now include Unicode letters (non-ASCII characters).

    if not re.match(r"^[\w .-]*$", query):        message = (            "Invalid query value provided. "-           "Only alphanumeric characters, hyphens, spaces, and underscores are allowed."+           "Only word characters (letters, numbers, underscores), periods, hyphens, and spaces are allowed."        )        raise ValidationError(message)

backend/tests/apps/core/validators_test.py (2)

98-98:Good test case addition for non-ASCII characters and periods.

The addition of the test case"çal Q. query" properly validates that the new regex pattern accepts non-ASCII characters (ç) and periods (.).

Consider expanding the test coverage by adding dedicated test cases intest_invalid_query for some of the specific invalid characters mentioned in the PR objectives (e.g.,!,@,#, etc.) to ensure they're properly rejected.

---

78-94:Enhance invalid query test coverage.

The current test suite only verifies that queries with exclamation marks (!) are rejected. Since the PR defines several invalid characters, it would be beneficial to add more test cases to ensure all specified invalid characters are properly rejected.

Consider adding more parameterized test cases totest_invalid_query to validate that queries containing other specified invalid characters (e.g.,@,#,$, etc.) are also rejected correctly.

    @pytest.mark.parametrize(        ("query", "error_message"),        [            (5, "query must be a string."),            (                "query!name",                (                    "Invalid query value provided. "                    "Only alphanumeric characters, hyphens, spaces, and underscores are allowed."                ),            ),+           (+               "query@name",+               (+                   "Invalid query value provided. "+                   "Only alphanumeric characters, hyphens, spaces, and underscores are allowed."+               ),+           ),+           (+               "query#name",+               (+                   "Invalid query value provided. "+                   "Only alphanumeric characters, hyphens, spaces, and underscores are allowed."+               ),+           ),+           # Add more invalid characters as needed        ],    )

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro