Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

style: Fix PTH208 use of pathlib#5238

Open
arohanajit wants to merge10 commits intoOSGeo:main
base:main
Choose a base branch
Loading
fromarohanajit:ruff-pth208

Conversation

arohanajit
Copy link
Contributor

Replacedos.listdir() toPath.iterdir() and variations of it

@github-actionsgithub-actionsbot added GUIwxGUI related PythonRelated code is in Python libraries module docs general testsRelated to Test Suite labelsFeb 28, 2025
@wenzeslauswenzeslaus changed the titlestyle: PTH208: FIxed PTH208 - use of `pathlibstyle: Fix PTH208 use of pathlibMar 1, 2025
@echoix
Copy link
Member

I still don't understand what's going on here

@arohanajit
Copy link
ContributorAuthor

I still don't understand what's going on here

This PR was supposed to fix all thePTH208 errors to replaceos.listdir() and similar withPathlib functions. However, there are quite a few dependencies where functions expect data is the exact formatos outputs them in. Replacing them withPath broke those dependencies, which I fixed over subsequent commits. Nearly all tests pass now but I am confused over what is causing this last test to fail

@petrasovaa
Copy link
Contributor

This will take me a while to review, for these more difficult ones, consider smaller PRs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docsgeneralGUIwxGUI relatedlibrariesmodulePythonRelated code is in PythontestsRelated to Test Suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@arohanajit@echoix@petrasovaa
[8]ページ先頭
©2009-2025 Movatter.jp