- Notifications
You must be signed in to change notification settings - Fork3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Add mode support and customizeable modes trying to get to the ability to customize modes#4877
base:master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview forohif-dev ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
❌ Deploy Preview forohif-platform-docs failed.Why did it fail? →
|
Viewers | ||||||||||||||||||||||||||||||||||
| Project | Viewers |
| Branch Review | feat/mode-support |
| Run status | |
| Run duration | 02m 13s |
| Commit | |
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 1 |
 Flaky | 0 |
 Pending | 2 |
 Skipped | 0 |
 Passing | 42 |
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/volume/MPR.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF MPR > should correctly render Crosshairs for MPR | Test ReplayScreenshotsVideo | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pedrokohler - add this file to your PR, and add the toolbar button and toolbar section to this file.
| 'UltrasoundDirectionalTool', | ||
| 'WindowLevelRegion', | ||
| ]); | ||
| toolbarService.addButtons(getCustomization('toolbarButtons')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pedrokohler - to customize the toolbar, you will also need these two lines, and to create a new custom section that extends the default tools/buttons.
Context
This PR starts allowing modes to be customized with the customization framework.
The idea is that a common set of definitions can be defined within the extensions, and then used to register the mode in a way that allows specific changes to be made to the underlying registration/setup.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment