- Notifications
You must be signed in to change notification settings - Fork3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[WIP] fix: Range measurements#4820
Open
wayfarer3130 wants to merge3 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
✅ Deploy Preview forohif-platform-docs ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
✅ Deploy Preview forohif-dev ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
Viewers | ||||||||||||||||||||||||||||||||||||||||
| Project | Viewers |
| Branch Review | fix/range-measurements |
| Run status | |
| Run duration | 02m 11s |
| Commit | |
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 2 |
 Flaky | 0 |
 Pending | 2 |
 Skipped | 0 |
 Passing | 42 |
| View all changes introduced in this branch ↗︎ | |
Tests for review
volume/MPR.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF MPR > should correctly render Crosshairs for MPR | Test ReplayScreenshotsVideo | |
measurement-tracking/OHIFDownloadSnapshotFile.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Download Snapshot File > checks displayed information for Desktop experience | Test ReplayScreenshotsVideo | |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Add context menu fixes to address a number of range measurement settings
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment