- Notifications
You must be signed in to change notification settings - Fork3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
SmartScrollbar component to show cached slices#4340
base:master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview forohif-platform-docs ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
✅ Deploy Preview forohif-dev canceled.
|
Cc :@Ouwen |
@sedghi is this something that could be in upstream? |
@Ouwen Hey guys, thanks, yes it can be. CCing our designer for this |
Hi everyone! I work as a UX designer on the OHIF team. This is amazing! Thank you for sharing! We would love to add this to OHIF. We are currently looking at some design updates that we'll want to apply here. I can take a look at those applied to this component at the end of this week (or early next) and share them here. Thank you again! ❤️ |
Hi there, thanks for this nice addition, I have a question about this statement The SmartScrollbar is only available in stack viewport as the number of imagesIds and the number of slices may vary in 2d MPR viewports. I wonder if it woundn't be possible to see things differently, rather then trying to mach the number of slice in the viewport consider the displayset loaded fraction. The displayset has a known number of frames so it would be possible to display how many slice of the display set have been loaded and this could work for a volume viewport no matter of its orientation. Maybe would need a bit different presentation. Could this PR be extended to another overlay maybe a progress circle to show the fraction of laoaded display set in case of a volume viewport ? |
d781297 to5fa622bCompare…layset and added an extra feature to prevent scrolling to uncached slices.
5fa622b tob2e4b28CompareWe were too busy with the rest of the component library, and still didn't have time to look at the design here, sorry about the delay |
We're sorry we couldn't include this in 3.9 due to other high priorities. We appreciate your patience and will review this, and give a design as soon as possible. |
Context
A Viewport scrollbar that shows the cached slices of the displayset loading in that viewport. Also, a feature was added to scroll only to the cached slices in normal scrolling operations. To force scrolling ( scrolling to uncached slices ) must press the Ctrl key when scrolling.
Changes & Results
A sample screenshot of the SmartScrollbar
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment