- Notifications
You must be signed in to change notification settings - Fork1.7k
feat(network-manager): add logger config passthrough for EDR networks#7738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
feat(network-manager): add logger config passthrough for EDR networks#7738
Conversation
Add support for passing logger configuration through to the EDR providerwhen creating simulated networks. This allows users to configure customlogging behavior via the network config.Changes:- Add logger field to EdrNetworkUserConfig and EdrNetworkConfig types- Pass logger config through resolveEdrNetwork to resolved config- Pass loggerConfig to createEdrProvider in network manager- Add zod validation schema for logger config- Add tests for config resolution and validation
|
Add support for passing logger configuration through to the EDR provider when creating simulated networks. This allows users to configure custom logging behavior via the network config.
Changes:
EdrNetworkUserConfigandEdrNetworkConfigtypesresolveEdrNetworkto resolved configloggerConfigtocreateEdrProviderin network managerImplementation note:
The
printLineFnandreplaceLastLineFnfields are typed asz.any()in validation since Zod doesn't have a built-in schema for validating callables. Runtime behavior will fail naturally if non-functions are passed.Closes#7737