Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(network-manager): add logger config passthrough for EDR networks#7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nikicat wants to merge1 commit intoNomicFoundation:main
base:main
Choose a base branch
Loading
fromnikicat:feat/edr-config-logger-passthrough

Conversation

@nikicat
Copy link

Add support for passing logger configuration through to the EDR provider when creating simulated networks. This allows users to configure custom logging behavior via the network config.

Changes:

  • Add logger field toEdrNetworkUserConfig andEdrNetworkConfig types
  • Pass logger config throughresolveEdrNetwork to resolved config
  • PassloggerConfig tocreateEdrProvider in network manager
  • Add zod validation schema for logger config
  • Add tests for config resolution and validation
  • Because this PR includes abug fix, relevant tests have been included.
  • Because this PR includes anew feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Implementation note:

TheprintLineFn andreplaceLastLineFn fields are typed asz.any() in validation since Zod doesn't have a built-in schema for validating callables. Runtime behavior will fail naturally if non-functions are passed.

Closes#7737

Add support for passing logger configuration through to the EDR providerwhen creating simulated networks. This allows users to configure customlogging behavior via the network config.Changes:- Add logger field to EdrNetworkUserConfig and EdrNetworkConfig types- Pass logger config through resolveEdrNetwork to resolved config- Pass loggerConfig to createEdrProvider in network manager- Add zod validation schema for logger config- Add tests for config resolution and validation
@changeset-bot
Copy link

⚠️ No Changeset found

Latest commit:e6bda6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@kanejkanej

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow suppressing console.log output for successful tests in EDR networks

2 participants

@nikicat@kanej

[8]ページ先頭

©2009-2025 Movatter.jp