Hey@jc21 can you please review this PR?

I have tried to use this version of NPM and pulled the docker image. When running this in Docker on Ubuntu using Firefox 138.0.4 (64-bit) when I go to add an SSL and select 'Custom' I get javascript errors 'InternalError: too much recursion - in main.bundle.js related to this line isNewhttp://0.0.0.0:81/js/17.bundle.17.js?v=2.12.3:1'. Have tried clearing cache etc, no good.

hey@asmwp thanks for looking at this. I will look into this and get back with the fix.

I've fixed the issue, I thoughtthis.isNew() inside a template function would refer to model function (new to backbone.js 😅). Fixed by directly checkingid. Create and Edit both features seems to work as expected now.

@asmwp can you have another look?

Docker Image for build 3 is available on
DockerHub
asnginxproxymanager/nginx-proxy-manager-dev:pr-4425

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

I didn't think it was working earlier but it was me being an idiot! I can confirm that this now works as expected in both Chrome and Firefox on Ubuntu.

nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Same for me. Don't forget to clear your cache/empty cache & hard reload. You'll see the Edit option after that. Much appreciated@rumansaleem