Bug Report

Summary of Current behaviour

If the game updates, or installed DLCs are changed, even if we have the hashes for the new LocatorIds, the app will still ingest and backup all the game files, just to remove them at the end of Synchronize (insideReprocessGameUpdates).

Synchronize uses the oldLocatorIds stored on the theLoadout to determine what the game state should look like, rather than looking at the newLocatorIds advertised by the game store.

This leads to all updates to fist be ingested into Override, just to then get removed a step later.

This can lead to long Apply times, as game updates can be of multiple GBs.

Details:

App currently only checks if theLocatorIds for the game have changed (e.g. Steam locatorIds) duringReprocessUpdates step which happens after Synchronization has already backed up and ingest new files and deletions into External changes.

Steps to reproduce

Adding a DLC will backup the DLC files and then discard them:

• Manage a Cyberpunk install without RedMod
• Close the app
• Add RedMod DLC from Steam or GOG
• Open the app and Apply (add a mod or do some other change to allow Applying)
• App will backup the REDmod DLC files as observable by the log line
• [DEBUG] Backing up 4721 files of 90.123 MB in size

Removing a DLC will put a bunch ofDeletedFile entries in External Changes

• Manage a Cyberpunk install with RedMod
• Close the app
• Remove RedMod from Steam or GOG
• Open the app and Apply
• All the RedMod files will be in Override as Deletion entries.

What is the expected behaviour?

App should realize that LocatorIds have changed early and avoid backing up or Ingesting game changes and instead use the correct locatorId data from the start.

Other information

QA Checklist:

• Add QA label if relevant
• Add repro steps
• Add expected behaviour
• Add known limitations with the fix or issues
• QA test Windows
• QA test Linux