- Notifications
You must be signed in to change notification settings - Fork266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(nerv-server): extend the method of renderVodeToString to support void and array vnode#158
Open
huyang2229 wants to merge1 commit intoNervJS:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedApr 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
使用Taro时，当用包裹多个条件表达式时，这时输出的快照不正确，原因在于Block包裹的子元素的vnode为Array类型且没有vType，而
nerv-server的renderVnodeToString没有对array类型的Vnode进行处理，具体截图如下：打了断点，相应的输出截图如下所示：
为了解决上述问题，在nerv-server库中的
renderVnodeToString方法中增加了对Array类型vnode的支持，此外对为覆盖到的void类型的vnode也进行了处理，避免snapshot中出现undefined字眼引起困惑。对变动增加了单测用例，并确保提交前所有测试用例均正常通过
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求: