Movatterモバイル変換

Skip to content

NativeScript/nativescript-angularPublic

NotificationsYou must be signed in to change notification settings
Fork240
Star1.2k

fix: polyfill global.Node for angular testing#2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

NathanWalker merged 2 commits intomasterfromedusperoni/node-polyfill

Apr 6, 2021

Merged

fix: polyfill global.Node for angular testing#2340

NathanWalker merged 2 commits intomasterfromedusperoni/node-polyfill

Apr 6, 2021

Conversation

@edusperoni

Copy link

Collaborator

edusperoni commentedMar 31, 2021

PR Checklist

The PR title follows our guidelines:https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed theCLA.
All existing tests are passing:https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests
Tests for the changes are included.

What is the current behavior?

Angular 11 introduced a regression where they checkinstanceof Node, but Node is not polyfilled by Nativescript so it errors out.

What is the new behavior?

Node is polyfilled with a dummy class.

Fixes#2311.

@edusperoni

fix: polyfill global.Node for angular testing

f573e1e

@cla-bot

cla-botbot added the cla: yes label

@edusperoni

Merge branch 'master' into edusperoni/node-polyfill

0f83dfd

@NathanWalker

NathanWalker merged commitc4ab491 intomaster

@NathanWalker

NathanWalker deleted the edusperoni/node-polyfill branch

April 6, 2021 20:22

@cwolff-wells

cwolff-wells mentioned this pull request

Unit Testing with ns7NativeScript/NativeScript#9346

Open

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

3 participants

@edusperoni

@NathanWalker

[8]ページ先頭

©2009-2025 Movatter.jp