Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork240
fix: Cannot reattach ActivatedRouteSnapshot created from a different …#2279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Please don't merge this yet, as it seems it might not fully solve the issue |
jcarolus commentedNov 24, 2020
@edusperoni@NathanaelA |
…route
PR Checklist
What is the current behavior?
Navigating between sibling routes may sometimes mess with the cache due to it using the key of a parent route, instead of the complete route.
What is the new behavior?
This now uses the correct key from the farthest children of the route
PARTIALLYFixes#1993. (this issue has 2 problems on it: 1 is the one fixed in this PR, the other is that route guard/resolvers don't work on back navigation and may break navigation for a PRO)