Movatterモバイル変換

Skip to content

NativeScript/nativescript-angularPublic

NotificationsYou must be signed in to change notification settings
Fork240
Star1.2k

fix: Export injection token used by plugins#2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

NathanWalker merged 2 commits intoNativeScript:masterfromPeterStaev:fix/export-missing-token

Oct 12, 2020

Merged

fix: Export injection token used by plugins#2268

NathanWalker merged 2 commits intoNativeScript:masterfromPeterStaev:fix/export-missing-token

Oct 12, 2020

Conversation

@PeterStaev

Copy link

Contributor

PeterStaev commentedSep 26, 2020

PR Checklist

The PR title follows our guidelines:https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed theCLA.
All existing tests are passing:https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests
Tests for the changes are included.

What is the current behavior?

TheTEMPLATED_ITEMS_COMPONENT injection token is missing from the export, thus preventing ability to create plugins/other components that extend theTemplatedItemsComponent

What is the new behavior?

TheTEMPLATED_ITEMS_COMPONENT is re-exported

Fixes/Implements/Closes #[Issue Number].

@PeterStaev

fix: Export injection token used by plugins

012e984

@cla-bot

cla-botbot added the cla: yes label

@PeterStaev

Copy link

ContributorAuthor

PeterStaev commentedOct 1, 2020

@NathanWalker could we get this reviewed, merged and released with this weeks patches? Would love to finish updating my plugins 😉

@NathanWalker

Merge branch 'master' into fix/export-missing-token

34ad2ac

@NathanWalker

NathanWalker merged commit75865f2 intoNativeScript:master

@PeterStaev

PeterStaev deleted the fix/export-missing-token branch

October 12, 2020 08:07

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

2 participants

@PeterStaev

@NathanWalker

[8]ページ先頭

©2009-2025 Movatter.jp