Movatterモバイル変換

Skip to content

NativeScript/nativescript-angularPublic

NotificationsYou must be signed in to change notification settings
Fork240
Star1.2k

fix(ivy): nsRouterLinkActive works on nsRouterLink#2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

NathanWalker merged 1 commit intoNativeScript:masterfromedusperoni:router-link-fix

Mar 24, 2021

Merged

fix(ivy): nsRouterLinkActive works on nsRouterLink#2322

NathanWalker merged 1 commit intoNativeScript:masterfromedusperoni:router-link-fix

Mar 24, 2021

Conversation

@edusperoni

Copy link

Collaborator

edusperoni commentedFeb 2, 2021

PR Checklist

The PR title follows our guidelines:https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed theCLA.
All existing tests are passing:https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests
Tests for the changes are included.

What is the current behavior?

We were using an older implementation of routerLinkActive which was not ivy compatible

What is the new behavior?

Updates to latest angular routerLinkActive implementation

Fixes#2321.

@edusperoni

fix(ivy): nsRouterLinkActive works on nsRouterLink

90ce37d

@cla-bot

cla-botbot added the cla: yes label

@NathanWalker

NathanWalker merged commit13a3562 intoNativeScript:master

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

2 participants

@edusperoni

@NathanWalker

[8]ページ先頭

©2009-2025 Movatter.jp