Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(renderer): order not preserved#2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@edusperoni
Copy link
Collaborator

@edusperoniedusperoni commentedSep 21, 2020
edited
Loading

PR Checklist

What is the current behavior?

Ordering can be erratic when nesting ng-containers and templates. This is due topreviousSibling not being implemented and comment nodes not being properly respected

<ng-container><Labeltext="1"*ngIf="show"></Label><Labeltext="2"*ngIf="show"></Label></ng-container>

will render:

2
1

What is the new behavior?

The node list is now doubly linked (previousSibling andnextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.

<ng-container><Labeltext="1"*ngIf="show"></Label><Labeltext="2"*ngIf="show"></Label></ng-container>

will render
1
2

Fixes/Implements/Closes #[Issue Number].

bellalMohamed reacted with thumbs up emojibellalMohamed reacted with hooray emojibellalMohamed reacted with heart emojibellalMohamed reacted with rocket emoji
@cla-botcla-botbot added the cla: yes labelSep 21, 2020
@NathanWalkerNathanWalker merged commit07abb9e intoNativeScript:masterSep 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edusperoni@NathanWalker

[8]ページ先頭

©2009-2025 Movatter.jp