Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork240
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default Checking mergeability… Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:NativeScript/nativescript-angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:NativeScript/nativescript-angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:tachev/ivy
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
Uh oh!
There was an error while loading.Please reload this page.
- 4commits
- 18files changed
- 2contributors
Commits on Mar 13, 2019
chore: WIP for making this plugin follow the Angular Package Format a…
…nd support IvySteps for testing:- cd nativescript-angular- npm run pack- cd yourProj- npm i your nativescript-angular tgz- install `next` versions of all Angular deps- edit `node_modules/@angular/compiler-cli/src/ngcc/src/packages/dependency_resolver.js` in order to comment out the following code: // This entry point has dependencies that are missing // so remove it from the graph. // removeNodes(entryPoint, Array.from(missing)); <--- this line- enable Ivy in the tsconfig with: "angularCompilerOptions": { "enableIvy": true, "allowEmptyCodegenFiles": true, },- run ./node_modules/.bin/ivy-ngcc- edit nativescript-angular package.json in order to set `fesm2015/nativescript-angular.js` for both `main` and `module`- edit `fesm2015/nativescript-angular.js` in order to remove the duplicate `_0_Template`- edit `fesm2015/nativescript-angular.js` in order to move import { install } from 'tns-core-modules/globals';install(); on the first line- fix the nativescript-angular imports in your app and the AOT transformer: - edit `/Users/tachev/Work/Test/ngIvy/node_modules/nativescript-dev-webpack/transformers/ns-replace-bootstrap.js` and set ...transformers_1.insertStarImport(sourceFile, idPlatformNativeScript, 'nativescript-angular', firstNode, true), - edit your main.ts, app.module.ts and everywhere else in your app in order to import from `nativescript-angular'` instead of the deep imports- tns run android/ios --bundle --env.iosDimitarTachev committedMar 13, 2019
Commits on Mar 14, 2019
feat: ng-packager imporvements
vakrilov committedMar 14, 2019 docs: add known issues to ivy md
vakrilov committedMar 14, 2019
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff master...tachev/ivy
Uh oh!
There was an error while loading.Please reload this page.