Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
fix: Incorrect font icon size conversion to device pixels.#9910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
NathanWalker merged 4 commits intoNativeScript:alphafromCatchABus:image-font-icon-size-fixMay 18, 2022
Merged
fix: Incorrect font icon size conversion to device pixels.#9910
NathanWalker merged 4 commits intoNativeScript:alphafromCatchABus:image-font-icon-size-fixMay 18, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
NathanWalker approved these changesMay 15, 2022
NathanWalker pushed a commit that referenced this pull requestJul 9, 2022
NathanWalker pushed a commit that referenced this pull requestJul 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
What is the current behavior?
Since NS 6, font icons used with Image, ActionItem, and few more elements have bad sizing between the 2 platforms.
It seems there's been a mistake since the implementation of this feature and font size is multiplied with display density 'twice'.
What is the new behavior?
Font icons used with Image, ActionItem, and few more elements will have proper size in both platforms.
Note: In iOS, there was a pixel conversion that was wrong and also didn't run so it was dead and was consequently removed.
Fixes#8391.