Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
chore: first stage of rewriting animations#9892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
# Conflicts:#packages/core/color/color-common.ts#packages/core/color/index.d.ts
# Conflicts:#.eslintrc.json#packages/core/bundle-entry-points.ts#packages/core/ui/core/bindable/index.ts#packages/core/ui/styling/style-scope.ts#packages/core/xml/index.ts#packages/webpack5/src/configuration/base.ts#packages/webpack5/src/helpers/index.ts
allow Color constructor to take hsl/hsv
This causes unecessary `requestLayout`
# Conflicts:#apps/automated/package.json#apps/toolbox/package.json#apps/ui/package.json#package.json#packages/core/application/index.android.ts#packages/core/application/index.ios.ts#packages/core/package.json#packages/core/platforms/android/native-api-usage.json#packages/core/platforms/ios/TNSWidgets.xcframework/Info.plist#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64/TNSWidgets.framework/TNSWidgets#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64/dSYMs/TNSWidgets.framework.dSYM/Contents/Resources/DWARF/TNSWidgets#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/TNSWidgets.framework/Versions/A/Resources/Info.plist#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/TNSWidgets.framework/Versions/A/TNSWidgets#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/dSYMs/TNSWidgets.framework.dSYM/Contents/Resources/DWARF/TNSWidgets#packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-simulator/TNSWidgets.framework/TNSWidgets#packages/core/ui/text-base/text-base-common.ts#packages/webpack/package.json#packages/webpack/project.json
…an N parentWe can do this on both platforms. I could prevent memory leaks
# Conflicts:#packages/core/package.json
It could prevent errors when the client would be called while the runtime is deadNativeScript/android#1667
…change/augmentdelegates.also unset delegates in disposeNativeView to prevent memory leak
# Conflicts:#packages/core/ui/animation/animation-common.ts#packages/core/ui/animation/index.ios.ts#packages/core/ui/core/view/index.ios.ts#packages/core/ui/gestures/index.ios.ts#packages/core/ui/page/index.ios.ts#packages/core/ui/styling/style-scope.ts#packages/core/ui/text-base/index.ios.ts
…_rebuilt# Conflicts:#packages/core/ui/animation/index.android.ts
Hi team@NathanWalker@farfromrefug@rigor789@triniwiz ! I comment here because one of the reasons why I use the fork is this. Animations work better in the fork than in nativescript core. I think this PR is important, since animations are important today. This PR seems to have been shelved and doesn't seem to be merging anywhere near. Could this be re-evaluated to be able to merge for a version that is not too late? |
@vallemar thanks for bumping. I honestly had forgotten about since it was there for so long |
This is a draft of rewriting the Animation system in N:
Animationunaware of which properties can be animatedbackgroundColor(which means going back to JS in every single animation step!)autosizeUIViewPropertyAnimator. My issue right now is how to animate custom properties like text color.TODO:
Viewsubclass to define custom property animation handlingCSSPropertyandCSSAnimationProperty? have to figure out the real difference between the 2 as there is no inheritance :s Merging would allow any prop to be animated through css